From: "Michael S. Tsirkin" <mst@redhat.com>
To: arei.gonglei@huawei.com
Cc: peter.maydell@linaro.org, weidong.huang@huawei.com,
Chenliang <chenliang88@huawei.com>,
aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de,
kraxel@redhat.com, dmitry@daynix.com, akong@redhat.com,
armbru@redhat.com, lersek@redhat.com, marcel.a@redhat.com,
somlo@cmu.edu, luonengjun@huawei.com, peter.huangpeng@huawei.com,
alex.williamson@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, lcapitulino@redhat.com, rth@twiddle.net,
kwolf@redhat.com, peter.crosthwaite@xilinx.com,
imammedo@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running
Date: Mon, 7 Jul 2014 12:29:03 +0300 [thread overview]
Message-ID: <20140707092903.GA20212@redhat.com> (raw)
In-Reply-To: <1404724261-9412-1-git-send-email-arei.gonglei@huawei.com>
On Mon, Jul 07, 2014 at 05:10:56PM +0800, arei.gonglei@huawei.com wrote:
> From: Chenliang <chenliang88@huawei.com>
>
> Sometime, we want to modify boot order of vm without shutdown it.
> This sets of patches add one qmp to achieve it. And fix some little
> bug when device is hotpluged.
>
> Chenliang (5):
> bootindex: add *_boot_device_path function
> bootindex: reset bootindex when vm reset
> bootindex: delete boot index when device is removed
> bootindex: add qmp to set boot index when vm is running
> bootindex: fix memory leak when ppc sets boot index
Unfortunately at least for PC, boot order is exposed
in fw cfg which can not change while guest is running.
I suspect we need to change how we report boot order to guests.
While we are at it, maybe we can fix the silly bootindex
convention: I think people really want to specify boot *order*,
not boot index.
> hmp.c | 11 ++++++++++
> hmp.h | 1 +
> hw/block/virtio-blk.c | 1 +
> hw/i386/kvm/pci-assign.c | 1 +
> hw/misc/vfio.c | 1 +
> hw/net/e1000.c | 1 +
> hw/net/eepro100.c | 1 +
> hw/net/ne2000.c | 1 +
> hw/net/rtl8139.c | 1 +
> hw/net/virtio-net.c | 1 +
> hw/net/vmxnet3.c | 1 +
> hw/nvram/fw_cfg.c | 53 +++++++++++++++++++++++++++++++++++++++------
> hw/ppc/spapr.c | 1 +
> hw/scsi/scsi-generic.c | 1 +
> hw/usb/dev-network.c | 1 +
> hw/usb/host-libusb.c | 1 +
> hw/usb/redirect.c | 1 +
> include/hw/nvram/fw_cfg.h | 2 ++
> include/sysemu/sysemu.h | 4 ++++
> qapi-schema.json | 16 ++++++++++++++
> qmp-commands.hx | 16 ++++++++++++++
> qmp.c | 14 ++++++++++++
> vl.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++
> 23 files changed, 179 insertions(+), 7 deletions(-)
>
> --
> 1.7.12.4
>
next prev parent reply other threads:[~2014-07-07 9:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 9:10 [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running arei.gonglei
2014-07-07 9:10 ` [Qemu-devel] [RFC PATCH 1/5] bootindex: add *_boot_device_path function arei.gonglei
2014-07-08 8:33 ` Amos Kong
2014-07-08 11:02 ` ChenLiang
2014-07-08 13:22 ` Gonglei (Arei)
2014-07-08 14:55 ` Amos Kong
2014-07-09 1:03 ` Gonglei (Arei)
2014-07-07 9:10 ` [Qemu-devel] [RFC PATCH 2/5] bootindex: reset bootindex when vm reset arei.gonglei
2014-07-07 9:10 ` [Qemu-devel] [RFC PATCH 3/5] bootindex: delete boot index when device is removed arei.gonglei
2014-07-07 9:11 ` [Qemu-devel] [RFC PATCH 4/5] bootindex: add qmp to set boot index when vm is running arei.gonglei
2014-07-07 9:11 ` [Qemu-devel] [RFC PATCH 5/5] bootindex: fix memory leak when set boot index arei.gonglei
2014-07-07 9:29 ` Michael S. Tsirkin [this message]
2014-07-07 10:03 ` [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running Laszlo Ersek
2014-07-07 11:12 ` Gonglei (Arei)
2014-07-07 14:40 ` Laszlo Ersek
2014-07-08 0:54 ` Gonglei (Arei)
2014-07-07 11:08 ` Gonglei (Arei)
2014-07-07 13:07 ` Michael S. Tsirkin
2014-07-08 1:06 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707092903.GA20212@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=akong@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=chenliang88@huawei.com \
--cc=dmitry@daynix.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=luonengjun@huawei.com \
--cc=marcel.a@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=somlo@cmu.edu \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).