From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X45Cs-00073o-Cj for qemu-devel@nongnu.org; Mon, 07 Jul 2014 05:27:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X45Cn-0005x6-IW for qemu-devel@nongnu.org; Mon, 07 Jul 2014 05:27:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X45Cn-0005wr-9t for qemu-devel@nongnu.org; Mon, 07 Jul 2014 05:27:25 -0400 Date: Mon, 7 Jul 2014 12:29:03 +0300 From: "Michael S. Tsirkin" Message-ID: <20140707092903.GA20212@redhat.com> References: <1404724261-9412-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404724261-9412-1-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: peter.maydell@linaro.org, weidong.huang@huawei.com, Chenliang , aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, kraxel@redhat.com, dmitry@daynix.com, akong@redhat.com, armbru@redhat.com, lersek@redhat.com, marcel.a@redhat.com, somlo@cmu.edu, luonengjun@huawei.com, peter.huangpeng@huawei.com, alex.williamson@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com, peter.crosthwaite@xilinx.com, imammedo@redhat.com, afaerber@suse.de On Mon, Jul 07, 2014 at 05:10:56PM +0800, arei.gonglei@huawei.com wrote: > From: Chenliang > > Sometime, we want to modify boot order of vm without shutdown it. > This sets of patches add one qmp to achieve it. And fix some little > bug when device is hotpluged. > > Chenliang (5): > bootindex: add *_boot_device_path function > bootindex: reset bootindex when vm reset > bootindex: delete boot index when device is removed > bootindex: add qmp to set boot index when vm is running > bootindex: fix memory leak when ppc sets boot index Unfortunately at least for PC, boot order is exposed in fw cfg which can not change while guest is running. I suspect we need to change how we report boot order to guests. While we are at it, maybe we can fix the silly bootindex convention: I think people really want to specify boot *order*, not boot index. > hmp.c | 11 ++++++++++ > hmp.h | 1 + > hw/block/virtio-blk.c | 1 + > hw/i386/kvm/pci-assign.c | 1 + > hw/misc/vfio.c | 1 + > hw/net/e1000.c | 1 + > hw/net/eepro100.c | 1 + > hw/net/ne2000.c | 1 + > hw/net/rtl8139.c | 1 + > hw/net/virtio-net.c | 1 + > hw/net/vmxnet3.c | 1 + > hw/nvram/fw_cfg.c | 53 +++++++++++++++++++++++++++++++++++++++------ > hw/ppc/spapr.c | 1 + > hw/scsi/scsi-generic.c | 1 + > hw/usb/dev-network.c | 1 + > hw/usb/host-libusb.c | 1 + > hw/usb/redirect.c | 1 + > include/hw/nvram/fw_cfg.h | 2 ++ > include/sysemu/sysemu.h | 4 ++++ > qapi-schema.json | 16 ++++++++++++++ > qmp-commands.hx | 16 ++++++++++++++ > qmp.c | 14 ++++++++++++ > vl.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++ > 23 files changed, 179 insertions(+), 7 deletions(-) > > -- > 1.7.12.4 >