From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X48ca-0000Du-Ex for qemu-devel@nongnu.org; Mon, 07 Jul 2014 09:06:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X48cW-0002C4-Qo for qemu-devel@nongnu.org; Mon, 07 Jul 2014 09:06:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X48cW-0002BR-IK for qemu-devel@nongnu.org; Mon, 07 Jul 2014 09:06:12 -0400 Date: Mon, 7 Jul 2014 16:07:52 +0300 From: "Michael S. Tsirkin" Message-ID: <20140707130751.GA22662@redhat.com> References: <1404724261-9412-1-git-send-email-arei.gonglei@huawei.com> <20140707092903.GA20212@redhat.com> <33183CC9F5247A488A2544077AF1902086C18E1E@SZXEMA503-MBS.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF1902086C18E1E@SZXEMA503-MBS.china.huawei.com> Subject: Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "peter.maydell@linaro.org" , "Huangweidong (C)" , "chenliang (T)" , "aik@ozlabs.ru" , "qemu-devel@nongnu.org" , "agraf@suse.de" , "kraxel@redhat.com" , "dmitry@daynix.com" , "akong@redhat.com" , "armbru@redhat.com" , "lersek@redhat.com" , "marcel.a@redhat.com" , "somlo@cmu.edu" , Luonengjun , "Huangpeng (Peter)" , "alex.williamson@redhat.com" , "stefanha@redhat.com" , "pbonzini@redhat.com" , "lcapitulino@redhat.com" , "rth@twiddle.net" , "kwolf@redhat.com" , "peter.crosthwaite@xilinx.com" , "imammedo@redhat.com" , "afaerber@suse.de" On Mon, Jul 07, 2014 at 11:08:32AM +0000, Gonglei (Arei) wrote: > > -----Original Message----- > > From: Michael S. Tsirkin [mailto:mst@redhat.com] > > Sent: Monday, July 07, 2014 5:29 PM > > To: Gonglei (Arei) > > Cc: qemu-devel@nongnu.org; afaerber@suse.de; agraf@suse.de; > > stefanha@redhat.com; akong@redhat.com; aik@ozlabs.ru; > > alex.williamson@redhat.com; armbru@redhat.com; eblake@redhat.com; > > kwolf@redhat.com; peter.maydell@linaro.org; lcapitulino@redhat.com; > > pbonzini@redhat.com; lersek@redhat.com; kraxel@redhat.com; > > imammedo@redhat.com; dmitry@daynix.com; marcel.a@redhat.com; > > peter.crosthwaite@xilinx.com; rth@twiddle.net; somlo@cmu.edu; > > Huangweidong (C); Luonengjun; Huangpeng (Peter); chenliang (T) > > Subject: Re: [RFC PATCH 0/5] modify boot order when vm is running > > > > On Mon, Jul 07, 2014 at 05:10:56PM +0800, arei.gonglei@huawei.com wrote: > > > From: Chenliang > > > > > > Sometime, we want to modify boot order of vm without shutdown it. > > > This sets of patches add one qmp to achieve it. And fix some little > > > bug when device is hotpluged. > > > > > > Chenliang (5): > > > bootindex: add *_boot_device_path function > > > bootindex: reset bootindex when vm reset > > > bootindex: delete boot index when device is removed > > > bootindex: add qmp to set boot index when vm is running > > > bootindex: fix memory leak when ppc sets boot index > > > > Unfortunately at least for PC, boot order is exposed > > in fw cfg which can not change while guest is running. > > Yes, so we should assure it take effect after the guest rebooting. Does this patch do it like this? I didn't get it. How is this handled? Maybe more code comments would be helpful to make this clear to readers. > > I suspect we need to change how we report boot order to guests. > > While we are at it, maybe we can fix the silly bootindex > > convention: I think people really want to specify boot *order*, > > not boot index. > > > Agreed. > > But at present, the boot index can be used for the boot order > except "-boot" command line. Because "-boot" only can assign > the guest booting from HD or Network or Floppy etc.. but cannot > assign the index of hard disks or PXE net cards, which not be enough > for many scenes, such as P2V, or two different system hard disks > (vda/sda/hda). > > > Best regards, > -Gonglei