From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4BA3-0000Cs-Vq for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:49:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4B9x-0002Tb-1i for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:48:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4B9w-0002TO-Po for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:48:52 -0400 Date: Mon, 7 Jul 2014 17:48:45 +0200 From: "Dr. David Alan Gilbert" Message-ID: <20140707154845.GF3443@work-vm> References: <1404495717-4239-1-git-send-email-dgilbert@redhat.com> <1404495717-4239-2-git-send-email-dgilbert@redhat.com> <53BAC0E8.9090608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53BAC0E8.9090608@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/46] qemu_ram_foreach_block: pass up error value, and down the ramblock name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, lilei@linux.vnet.ibm.com * Eric Blake (eblake@redhat.com) wrote: > On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > check the return value of the function it calls and error if it's none-0 > > Fixup qemu_rdma_init_one_block that is the only current caller, > > and __qemu_rdma_add_block the only function it calls using it. > > As long as you are at it, is it worth renaming the use of __qemu prefix > in a function name? That namespace is reserved for the compiler/libc, > and we shouldn't be stomping on it. Probably best as a separate patch. Yeh it sounds separate, but worth doing but this was getting a large enough set of patches already. Dave > > > > > Pass the name of the ramblock to the function; helps in debugging. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > exec.c | 10 ++++++++-- > > include/exec/cpu-common.h | 4 ++-- > > migration-rdma.c | 4 ++-- > > 3 files changed, 12 insertions(+), 6 deletions(-) > > Reviewed-by: Eric Blake > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK