qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.1] block: Fix bdrv_is_allocated() return value
Date: Tue, 8 Jul 2014 14:57:41 +0200	[thread overview]
Message-ID: <20140708125741.GC3857@noname.str.redhat.com> (raw)
In-Reply-To: <1404747446-10215-1-git-send-email-kwolf@redhat.com>

Am 07.07.2014 um 17:37 hat Kevin Wolf geschrieben:
> bdrv_is_allocated() should return either 0 or 1 in successful cases.
> We're lucky that currently, the callers that rely on this (e.g. because
> they check for ret == 1) don't seem to break badly. They just might skip
> some optimisation or in the case of qemu-io 'map' print separate lines
> where a single line would suffice. In theory, a wrong allocation status
> could lead to image corruption with certain operations, so let's fix
> this quickly.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Applied to the block branch.

Kevin

      parent reply	other threads:[~2014-07-08 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07 15:37 [Qemu-devel] [PATCH for-2.1] block: Fix bdrv_is_allocated() return value Kevin Wolf
2014-07-07 15:50 ` Eric Blake
2014-07-08 12:57 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708125741.GC3857@noname.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).