From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38223)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1X4X6e-0002KO-H0
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 11:15:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1X4X6Y-000290-BA
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 11:14:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1X4X6Y-00028u-1J
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 11:14:50 -0400
Date: Tue, 8 Jul 2014 17:14:42 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140708151442.GG3857@noname.str.redhat.com>
References: <1404228309-21122-1-git-send-email-stefanha@redhat.com>
	<CAJSP0QXi+2buuKHB6dTdiqH=Bhny3GFujAoVOA3t4rEhHV592w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJSP0QXi+2buuKHB6dTdiqH=Bhny3GFujAoVOA3t4rEhHV592w@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified
 virtio-blk request handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Ming Lei <ming.lei@canonical.com>, Fam Zheng <famz@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Am 08.07.2014 um 16:43 hat Stefan Hajnoczi geschrieben:
> On Tue, Jul 1, 2014 at 5:25 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > This series fixes issues recently introduced when unifying virtio-blk
> > dataplane's request handling with non-dataplane virtio-blk.
> >
> > The problems include broken memory allocation for dataplane requests and a
> > performance regression for non-dataplane.  See the patches for details.
> >
> > Stefan Hajnoczi (4):
> >   virtio-blk: avoid dataplane VirtIOBlockReq early free
> >   dataplane: do not free VirtQueueElement in vring_push()
> >   virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and
> >     VirtQueueElement
> >   virtio-blk: embed VirtQueueElement in VirtIOBlockReq
> >
> >  hw/block/dataplane/virtio-blk.c     | 30 +++++++++++-----------
> >  hw/block/virtio-blk.c               | 50 ++++++++++++++++++-------------------
> >  hw/virtio/dataplane/vring.c         | 22 ++++++----------
> >  include/hw/virtio/dataplane/vring.h |  3 +--
> >  include/hw/virtio/virtio-blk.h      |  6 ++++-
> >  5 files changed, 53 insertions(+), 58 deletions(-)
> 
> Hi Kevin,
> Please include this series in your block pull request.  I missed it
> last week and it's needed to fix dataplane in QEMU 2.1.

Patch 4 doesn't seem to apply any more. Can you rebase (and include the
Tested-by tags of Christian)?

Kevin