From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4bsA-0003w6-7G for qemu-devel@nongnu.org; Tue, 08 Jul 2014 16:20:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4bs9-0005tl-7r for qemu-devel@nongnu.org; Tue, 08 Jul 2014 16:20:18 -0400 Received: from zeniv.linux.org.uk ([2002:c35c:fd02::1]:50139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4bs9-0005ta-0O for qemu-devel@nongnu.org; Tue, 08 Jul 2014 16:20:17 -0400 Date: Tue, 8 Jul 2014 21:20:15 +0100 From: Al Viro Message-ID: <20140708202015.GG18016@ZenIV.linux.org.uk> References: <53BAC8CC.9070301@twiddle.net> <20140708042037.GA18016@ZenIV.linux.org.uk> <53BB899C.30901@twiddle.net> <20140708065436.GB18016@ZenIV.linux.org.uk> <20140708071334.GA21956@ZenIV.linux.org.uk> <20140708161351.GC18016@ZenIV.linux.org.uk> <53BC3484.9050802@twiddle.net> <20140708190259.GE18016@ZenIV.linux.org.uk> <53BC40AA.4090707@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53BC40AA.4090707@twiddle.net> Sender: Al Viro Subject: Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Peter Maydell , QEMU Developers On Tue, Jul 08, 2014 at 12:04:10PM -0700, Richard Henderson wrote: > > Just one thing - 0x1fffffffffffff will make 32bit hosts whine about integer > > constant being too large. So will 0x1ffffffffffffful, unfortunately - it > > really ought to be ull. > > > > I did use ull on the branch. Aha... So you've caught that one already... I've looked at your branch; AFAICS, the only thing missing there is treating stores to FPCR.DNOD in system mode as "not implemented" (which it is in the code as well as in 21[0-3]64 hardware). Other than that everything seems to be fine; you are right about cvtql treatment - since that sucker doesn't have /i in any allowed trap suffices, we might as well just raise Inexact and let it be masked out - float_flag_inexact will be present in 'ignore'. And yes, folding the calculation itself in there obviously makes sense.