From: Amit Shah <amit.shah@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>, Peter Lieven <pl@kamp.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load
Date: Wed, 9 Jul 2014 16:14:57 +0530 [thread overview]
Message-ID: <20140709104457.GE27615@grmbl.mre> (raw)
In-Reply-To: <CAFEAcA-FA=f4zhW6XJa+e5RKuihiVyOxE_xLdaRKAwFAquus=A@mail.gmail.com>
On (Wed) 09 Jul 2014 [11:28:27], Peter Maydell wrote:
> On 9 July 2014 05:25, Amit Shah <amit.shah@redhat.com> wrote:
> > (CC'ing Peter Maydell for his thoughts)
> >
> > On (Tue) 08 Jul 2014 [22:55:42], Peter Lieven wrote:
> >> Hi Juan,
> >>
> >> Am 25.06.2014 um 13:55 schrieb Juan Quintela <quintela@redhat.com>:
> >>
> >> > Peter Lieven <pl@kamp.de> wrote:
> >> >> this patch extends commit db80fac by not only checking
> >> >> for unknown flags, but also filtering out unknown flag
> >> >> combinations.
> >> >>
> >> >> Suggested-by: Eric Blake <eblake@redhat.com>
> >> >> Signed-off-by: Peter Lieven <pl@kamp.de>
> >> >
> >> > Reviewed-by: Juan Quintela <quintela@redhat.com>
> >> >
> >> > Will be on next pull request, thanks.
> >> >
> >>
> >> Have you forgotten to pull this one? It might be too late for 2.1 though.
> >
> > Juan is away for a couple of weeks. This looks like a good fix to
> > pull in for 2.1, though. Peter, do you agree? Can you pick this up
> > if so?
>
> What's the bug it's fixing? I had a look at the commit message,
> but that suggests it's just tightening up sanity checking, not
> fixing an actual issue... Maybe you can clarify.
Right, it improves correctness: after this patch, we ensure a rogue or
corrupt migration stream cannot cause problems on the dest.
Amit
next prev parent reply other threads:[~2014-07-09 10:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 9:32 [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load Peter Lieven
2014-06-24 15:49 ` Eric Blake
2014-06-25 11:55 ` Juan Quintela
2014-07-08 20:55 ` Peter Lieven
2014-07-09 4:25 ` Amit Shah
2014-07-09 10:28 ` Peter Maydell
2014-07-09 10:44 ` Amit Shah [this message]
2014-07-09 10:50 ` Peter Maydell
2014-07-09 10:56 ` Amit Shah
2014-07-09 11:00 ` Peter Maydell
2014-07-09 13:23 ` Peter Lieven
2014-07-09 13:55 ` Eric Blake
2014-07-11 12:52 ` Amit Shah
2014-08-21 21:57 ` Peter Lieven
2014-08-22 3:57 ` Amit Shah
2014-09-02 9:17 ` Peter Lieven
2014-09-23 9:46 ` Paolo Bonzini
2014-09-23 9:51 ` Paolo Bonzini
2014-09-30 6:38 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709104457.GE27615@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).