From: Kevin Wolf <kwolf@redhat.com>
To: Liu Yuan <namei.unix@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Benoit Canet <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH] block/quorum: make quorum_getlength error message user friendly
Date: Fri, 11 Jul 2014 12:26:58 +0200 [thread overview]
Message-ID: <20140711102658.GA3976@noname.redhat.com> (raw)
In-Reply-To: <1405064065-10021-1-git-send-email-namei.unix@gmail.com>
Am 11.07.2014 um 09:34 hat Liu Yuan geschrieben:
> When start quorum driver with 2 different sized images, we get:
>
> qemu-system-x86_64: -drive if=virtio,driver=quorum...: Could not refresh total \
> sector count: Input/output error
>
> EIO would confuse users. With this patch, the error message goes like
>
> Children images are not in the same size
> qemu-system-x86_64: -drive if=virtio,driver=quorum...: Could not refresh total \
> sector count: Invalid argument
>
> Cc: Benoit Canet <benoit@irqsave.net>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
I think it would be better to do this check in quorum_open() instead of
relying on bdrv_open() to perform a bdrv_getlength(). As a bonus,
quorum_open() has an Error argument, so we wouldn't have to use
something like error_printf(), which doesn't work well for QMP commands.
Kevin
next prev parent reply other threads:[~2014-07-11 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 7:34 [Qemu-devel] [PATCH] block/quorum: make quorum_getlength error message user friendly Liu Yuan
2014-07-11 10:26 ` Kevin Wolf [this message]
2014-07-12 3:42 ` Liu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711102658.GA3976@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=benoit@irqsave.net \
--cc=namei.unix@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).