From: Amit Shah <amit.shah@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>, Peter Lieven <pl@kamp.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load
Date: Fri, 11 Jul 2014 18:22:26 +0530 [thread overview]
Message-ID: <20140711125226.GA17415@grmbl.mre> (raw)
In-Reply-To: <CAFEAcA_fswzzvecPw4n_2b45jwUNoay6_j3arMEJWGRmm9+xvg@mail.gmail.com>
On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote:
> On 9 July 2014 11:56, Amit Shah <amit.shah@redhat.com> wrote:
> > On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote:
> >> OK; we're treating those as bugs so yes, I think this is 2.1
> >> material. Has somebody other than the original author tested
> >> it? (That's a step that would usually be done by Juan as the
> >> maintainer.) If somebody can provide a Tested-by: I'm happy
> >> to apply it to master.
> >
> > Not really sure if Juan did that as part of his 'thanks, applied'
> > workflow, but I'll run this through the autotest migration tests and
> > report back.
>
> Thanks; it seems better to double-check given where we are in
> the release cycle.
I tested using the autotest migration tests, which start a guest,
migrate it, and then login to the guest to see if everything's fine.
I used qemu-2.0 and qemu.git against qemu.git+patch and both tests
passed fine.
But since Peter and Eric have reservations, let's just postpone this
till 2.2. That saves me from further tests as well!
Amit
next prev parent reply other threads:[~2014-07-11 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 9:32 [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load Peter Lieven
2014-06-24 15:49 ` Eric Blake
2014-06-25 11:55 ` Juan Quintela
2014-07-08 20:55 ` Peter Lieven
2014-07-09 4:25 ` Amit Shah
2014-07-09 10:28 ` Peter Maydell
2014-07-09 10:44 ` Amit Shah
2014-07-09 10:50 ` Peter Maydell
2014-07-09 10:56 ` Amit Shah
2014-07-09 11:00 ` Peter Maydell
2014-07-09 13:23 ` Peter Lieven
2014-07-09 13:55 ` Eric Blake
2014-07-11 12:52 ` Amit Shah [this message]
2014-08-21 21:57 ` Peter Lieven
2014-08-22 3:57 ` Amit Shah
2014-09-02 9:17 ` Peter Lieven
2014-09-23 9:46 ` Paolo Bonzini
2014-09-23 9:51 ` Paolo Bonzini
2014-09-30 6:38 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711125226.GA17415@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).