From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51022)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X5aK6-0002HY-2O
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 08:53:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X5aJz-0004ad-TL
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 08:53:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63599)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X5aJz-0004aL-KH
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 08:53:03 -0400
Date: Fri, 11 Jul 2014 18:22:26 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20140711125226.GA17415@grmbl.mre>
References: <1403602356-13687-1-git-send-email-pl@kamp.de>
	<874mz919w5.fsf@troll.troll>
	<DA7943F0-2634-4842-A9E6-188F8C0CDD12@kamp.de>
	<20140709042557.GA10283@grmbl.mre>
	<CAFEAcA-FA=f4zhW6XJa+e5RKuihiVyOxE_xLdaRKAwFAquus=A@mail.gmail.com>
	<20140709104457.GE27615@grmbl.mre>
	<CAFEAcA_vRh9fE9=D_8w6MVbapRJWYfinbjheCPpgjY+BoT_=_Q@mail.gmail.com>
	<20140709105620.GG27615@grmbl.mre>
	<CAFEAcA_fswzzvecPw4n_2b45jwUNoay6_j3arMEJWGRmm9+xvg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_fswzzvecPw4n_2b45jwUNoay6_j3arMEJWGRmm9+xvg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations
	in ram_load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>, Peter Lieven <pl@kamp.de>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote:
> On 9 July 2014 11:56, Amit Shah <amit.shah@redhat.com> wrote:
> > On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote:
> >> OK; we're treating those as bugs so yes, I think this is 2.1
> >> material. Has somebody other than the original author tested
> >> it? (That's a step that would usually be done by Juan as the
> >> maintainer.) If somebody can provide a Tested-by: I'm happy
> >> to apply it to master.
> >
> > Not really sure if Juan did that as part of his 'thanks, applied'
> > workflow, but I'll run this through the autotest migration tests and
> > report back.
> 
> Thanks; it seems better to double-check given where we are in
> the release cycle.

I tested using the autotest migration tests, which start a guest,
migrate it, and then login to the guest to see if everything's fine.

I used qemu-2.0 and qemu.git against qemu.git+patch and both tests
passed fine.

But since Peter and Eric have reservations, let's just postpone this
till 2.2.  That saves me from further tests as well!


		Amit