From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5cxg-00051A-PD for qemu-devel@nongnu.org; Fri, 11 Jul 2014 11:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5cxb-0002TZ-1X for qemu-devel@nongnu.org; Fri, 11 Jul 2014 11:42:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5cxa-0002TA-KG for qemu-devel@nongnu.org; Fri, 11 Jul 2014 11:42:06 -0400 Date: Fri, 11 Jul 2014 16:41:59 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20140711154158.GA11534@work-vm> References: <1404495717-4239-1-git-send-email-dgilbert@redhat.com> <1404495717-4239-38-git-send-email-dgilbert@redhat.com> <53C000D0.2090209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53C000D0.2090209@redhat.com> Subject: Re: [Qemu-devel] [PATCH 37/46] Add assertion to check migration_dirty_pages doesn't go -ve; have seen it happen once but not sure why List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, lilei@linux.vnet.ibm.com * Eric Blake (eblake@redhat.com) wrote: > On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > Long subject line. Also, spell out "negative" instead of abbreviating "-ve" Fixed. Dave > > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > arch_init.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch_init.c b/arch_init.c > > index c006d21..58eccc1 100644 > > --- a/arch_init.c > > +++ b/arch_init.c > > @@ -439,6 +439,7 @@ ram_addr_t migration_bitmap_find_and_reset_dirty(MemoryRegion *mr, > > > > if (next < size) { > > clear_bit(next, migration_bitmap); > > + assert(migration_dirty_pages > 0); > > migration_dirty_pages--; > > } > > *bitoffset = next; > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK