From: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
To: snabb-devel@googlegroups.com, qemu-devel@nongnu.org, mst@redhat.com
Cc: tech@virtualopensystems.com, n.nikolaev@virtualopensystems.com
Subject: [Qemu-devel] [PATCH v2 0/2 for-2.1] vhost-user fixes
Date: Sat, 12 Jul 2014 04:42:02 +0300 [thread overview]
Message-ID: <20140712014119.10636.81503.stgit@3820> (raw)
The latest vhost-user changes changed the VHOST_SET_MEM_TABLE handling.
Now the memory regions are mapped from dev->mem. There is an error when calling
qemu_get_ram_fd with reg->guest_phys_addr. The right approach is to find the ram_addr_t
corresponding to the userspace_addr using qemu_ram_addr_from_host first.
Thanks to Paolo Bonzini for poinitng the real problem.
The related vhost-user qtest is also updated to reflect the changes in
vhost-user message structures.
Changes since v1:
- dropped the patches 1 and 2 and just fixed the "real issue"
---
Nikolay Nikolaev (2):
vhost-user: Fix VHOST_SET_MEM_TABLE processing
qtest: Adapt vhost-user-test to latehs vhost-user changes
hw/virtio/vhost-user.c | 4 +++-
tests/vhost-user-test.c | 11 +++++++++--
2 files changed, 12 insertions(+), 3 deletions(-)
--
Signature
next reply other threads:[~2014-07-12 1:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 1:42 Nikolay Nikolaev [this message]
2014-07-12 1:42 ` [Qemu-devel] [PATCH v2 1/2 for-2.1] vhost-user: Fix VHOST_SET_MEM_TABLE processing Nikolay Nikolaev
2014-07-12 5:07 ` Paolo Bonzini
2014-07-12 9:04 ` Nikolay Nikolaev
2014-07-12 1:43 ` [Qemu-devel] [PATCH v2 2/2 for-2.1] qtest: Adapt vhost-user-test to latehs vhost-user changes Nikolay Nikolaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712014119.10636.81503.stgit@3820 \
--to=n.nikolaev@virtualopensystems.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=snabb-devel@googlegroups.com \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).