From: Stefan Hajnoczi <stefanha@redhat.com>
To: arei.gonglei@huawei.com
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
weidong.huang@huawei.com, luonengjun@huawei.com,
qemu-devel@nongnu.org, daifulai@huawei.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.1] linux-aio: Fix laio resource leak
Date: Mon, 14 Jul 2014 10:12:36 +0200 [thread overview]
Message-ID: <20140714081236.GA2185@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1405136617-11184-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On Sat, Jul 12, 2014 at 11:43:37AM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> when hotplug virtio-scsi disks using laio, the aio_nr will
> increase in laio_init() by io_setup(), we can see the number by
> # cat /proc/sys/fs/aio-nr
> 128
> if the aio_nr attach the maxnum, which found from
> # cat /proc/sys/fs/aio-max-nr
> 65536
> the hotplug process will fail because of aio context leak.
>
> Fix it by io_destroy in laio_cleanup().
>
> Reported-by: daifulai <daifulai@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> v2: small spelling fixes.
> ---
> block/linux-aio.c | 5 +++++
> 1 file changed, 5 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-07-14 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 3:43 [Qemu-devel] [PATCH v2 for-2.1] linux-aio: Fix laio resource leak arei.gonglei
2014-07-14 8:12 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714081236.GA2185@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=daifulai@huawei.com \
--cc=kwolf@redhat.com \
--cc=luonengjun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).