* [Qemu-devel] [PATCH v2 for-2.1] linux-aio: Fix laio resource leak
@ 2014-07-12 3:43 arei.gonglei
2014-07-14 8:12 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: arei.gonglei @ 2014-07-12 3:43 UTC (permalink / raw)
To: qemu-devel
Cc: kwolf, peter.maydell, weidong.huang, luonengjun, daifulai,
Gonglei, stefanha, pbonzini
From: Gonglei <arei.gonglei@huawei.com>
when hotplug virtio-scsi disks using laio, the aio_nr will
increase in laio_init() by io_setup(), we can see the number by
# cat /proc/sys/fs/aio-nr
128
if the aio_nr attach the maxnum, which found from
# cat /proc/sys/fs/aio-max-nr
65536
the hotplug process will fail because of aio context leak.
Fix it by io_destroy in laio_cleanup().
Reported-by: daifulai <daifulai@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
v2: small spelling fixes.
---
block/linux-aio.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/linux-aio.c b/block/linux-aio.c
index 4867369..7ac7e8c 100644
--- a/block/linux-aio.c
+++ b/block/linux-aio.c
@@ -310,5 +310,10 @@ void laio_cleanup(void *s_)
struct qemu_laio_state *s = s_;
event_notifier_cleanup(&s->e);
+
+ if (io_destroy(s->ctx) != 0) {
+ fprintf(stderr, "%s: destroy AIO context %p failed\n",
+ __func__, &s->ctx);
+ }
g_free(s);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH v2 for-2.1] linux-aio: Fix laio resource leak
2014-07-12 3:43 [Qemu-devel] [PATCH v2 for-2.1] linux-aio: Fix laio resource leak arei.gonglei
@ 2014-07-14 8:12 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2014-07-14 8:12 UTC (permalink / raw)
To: arei.gonglei
Cc: kwolf, peter.maydell, weidong.huang, luonengjun, qemu-devel,
daifulai, pbonzini
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On Sat, Jul 12, 2014 at 11:43:37AM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> when hotplug virtio-scsi disks using laio, the aio_nr will
> increase in laio_init() by io_setup(), we can see the number by
> # cat /proc/sys/fs/aio-nr
> 128
> if the aio_nr attach the maxnum, which found from
> # cat /proc/sys/fs/aio-max-nr
> 65536
> the hotplug process will fail because of aio context leak.
>
> Fix it by io_destroy in laio_cleanup().
>
> Reported-by: daifulai <daifulai@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> v2: small spelling fixes.
> ---
> block/linux-aio.c | 5 +++++
> 1 file changed, 5 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-14 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-12 3:43 [Qemu-devel] [PATCH v2 for-2.1] linux-aio: Fix laio resource leak arei.gonglei
2014-07-14 8:12 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).