From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6eNP-0002Aq-Ut for qemu-devel@nongnu.org; Mon, 14 Jul 2014 07:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X6eNI-0000qU-CD for qemu-devel@nongnu.org; Mon, 14 Jul 2014 07:24:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X6eNH-0000pj-TN for qemu-devel@nongnu.org; Mon, 14 Jul 2014 07:24:52 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6EBOoKf021624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 14 Jul 2014 07:24:50 -0400 Date: Mon, 14 Jul 2014 12:24:47 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20140714112446.GJ2401@work-vm> References: <1405334675-16453-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405334675-16453-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH for 2.1] virtio-scsi: fix with -M pc-i440fx-2.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org * Paolo Bonzini (pbonzini@redhat.com) wrote: > Right now starting a machine with virtio-scsi and a <= 2.0 machine type > fails with: > > qemu-system-x86_64: -device virtio-scsi-pci: Property .any_layout not found > > This is because the any_layout bit was actually never set after > virtio-scsi was changed to support arbitrary layout for virtio buffers. > > (This was just a cleanup and a preparation for virtio 1.0; no guest > actually checks the bit, but the new request parsing algorithms are > tested even with old guest). > > Reported-by: David Gilbert > Signed-off-by: Paolo Bonzini Seems to fix the bug I hit. Dave > --- > include/hw/virtio/virtio-scsi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h > index 0419ee4..188a2d9 100644 > --- a/include/hw/virtio/virtio-scsi.h > +++ b/include/hw/virtio/virtio-scsi.h > @@ -178,6 +178,8 @@ typedef struct { > DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128) > > #define DEFINE_VIRTIO_SCSI_FEATURES(_state, _feature_field) \ > + DEFINE_PROP_BIT("any_layout", _state, _feature_field, \ > + VIRTIO_F_ANY_LAYOUT, true), \ > DEFINE_PROP_BIT("hotplug", _state, _feature_field, VIRTIO_SCSI_F_HOTPLUG, \ > true), \ > DEFINE_PROP_BIT("param_change", _state, _feature_field, \ > -- > 1.9.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK