From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X6l3V-00024j-IM
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 14:32:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X6l3Q-0006SJ-H0
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 14:32:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41277)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X6l3Q-0006Rr-7w
	for qemu-devel@nongnu.org; Mon, 14 Jul 2014 14:32:48 -0400
Date: Mon, 14 Jul 2014 14:32:44 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140714143244.6a2ba286@redhat.com>
In-Reply-To: <53C42204.6070909@redhat.com>
References: <20140708141728.412a3f1c@redhat.com>
	<87fvi9i8tx.fsf@blackfin.pond.sub.org>
	<20140710103641.31b658c0@redhat.com>
	<87vbr4vtwp.fsf@blackfin.pond.sub.org>
	<53C004F2.1000602@redhat.com>
	<87tx6nsx3l.fsf@blackfin.pond.sub.org>
	<20140711145115.28849a0e@redhat.com> <53C05590.40409@redhat.com>
	<20140714141243.6390520f@redhat.com> <53C42204.6070909@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor
 extension
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: famz@redhat.com, Markus Armbruster <armbru@redhat.com>, wenchaoqemu@gmail.com, qemu-devel <qemu-devel@nongnu.org>

On Mon, 14 Jul 2014 12:31:32 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 07/14/2014 12:12 PM, Luiz Capitulino wrote:
> >>>> Agree.  Let's ditch nested structs and see whether there are any misuses
> >>>> of c_var() left.
> >>>
> >>> This is an honest question: do we really want to drop nested struct support,
> >>> wasn't it added by the block layer or am I just confused?
> >>
> >> We're talking about raw inline structs - there's only 3 impacted QAPI
> >> typesMP commands (if I counted correctly), and they have nothing to do
> >> with block layer complex structs.  The idea is that we want to outlaw
> >> 'foo':{...} implicit structs, and instead require 'foo':'type', where
> >> 'type' was earlier defined with the {...} guts.  The QMP wire format
> >> would be unchanged; it is just a change to the QAPI template that the
> >> generators read.  Removing inline structs would also simplify the
> >> generators.  Then, with that gone, we are free to to repurpose
> >> 'foo':{...} for default values of optional arguments.  Here's a link to
> >> some of the earlier conversation:
> >>
> >> https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html
> >> https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg04268.html
> > 
> > Right, this makes sense. Thanks for the URLs.
> > 
> > Is there anyone planning on doing this? I don't think I'll have cycles
> > anytime soon... I'd be willing to merge my fix if nobody steps up.
> 
> I may take a stab at removing raw inline structs after 2.1 is released,
> if no one beats me to it.

Great! Thanks a lot.