From: Amit Shah <amit.shah@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-rng: Add human-readable error message for negative max-bytes parameter
Date: Tue, 15 Jul 2014 14:51:55 +0530 [thread overview]
Message-ID: <20140715092155.GA2477@grmbl.mre> (raw)
In-Reply-To: <20140715091831.GA4613@stefanha-thinkpad.redhat.com>
On (Tue) 15 Jul 2014 [11:18:31], Stefan Hajnoczi wrote:
> On Tue, Jul 15, 2014 at 10:21:47AM +0530, Amit Shah wrote:
> > On (Mon) 14 Jul 2014 [19:14:43], John Snow wrote:
> > > If a negative integer is used for the max_bytes parameter, QEMU currently
> > > calls abort() and leaves behind a core dump. This patch adds a simple
> > > error message to make the reason for the termination clearer.
> > >
> > > Signed-off-by: John Snow <jsnow@redhat.com>
> >
> > Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> Amit, are you sending a pull request? I'm not sure whose tree this goes
> through.
Yes, I'll do that.
Amit
prev parent reply other threads:[~2014-07-15 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 23:14 [Qemu-devel] [PATCH] virtio-rng: Add human-readable error message for negative max-bytes parameter John Snow
2014-07-15 4:51 ` Amit Shah
2014-07-15 9:18 ` Stefan Hajnoczi
2014-07-15 9:21 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715092155.GA2477@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).