From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44101)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X6ywU-0004CD-Ns
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 05:22:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X6ywO-0003eB-KL
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 05:22:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40467)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X6ywO-0003dl-DP
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 05:22:28 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6F9MRtk017687
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 15 Jul 2014 05:22:27 -0400
Date: Tue, 15 Jul 2014 14:51:55 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20140715092155.GA2477@grmbl.mre>
References: <1405379683-4672-1-git-send-email-jsnow@redhat.com>
	<20140715045147.GC26186@grmbl.mre>
	<20140715091831.GA4613@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140715091831.GA4613@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-rng: Add human-readable error
 message for negative max-bytes parameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org

On (Tue) 15 Jul 2014 [11:18:31], Stefan Hajnoczi wrote:
> On Tue, Jul 15, 2014 at 10:21:47AM +0530, Amit Shah wrote:
> > On (Mon) 14 Jul 2014 [19:14:43], John Snow wrote:
> > > If a negative integer is used for the max_bytes parameter, QEMU currently
> > > calls abort() and leaves behind a core dump. This patch adds a simple
> > > error message to make the reason for the termination clearer.
> > > 
> > > Signed-off-by: John Snow <jsnow@redhat.com>
> > 
> > Reviewed-by: Amit Shah <amit.shah@redhat.com>
> 
> Amit, are you sending a pull request?  I'm not sure whose tree this goes
> through.

Yes, I'll do that.


		Amit