From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55013)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X6zYA-0003nW-29
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 06:01:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X6zY3-0006a1-Ut
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 06:01:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42706)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1X6zY3-0006Za-NS
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 06:01:23 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6FA1M42028536
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 15 Jul 2014 06:01:22 -0400
Date: Tue, 15 Jul 2014 15:30:51 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20140715100051.GB2477@grmbl.mre>
References: <339156532cdc68672d36d0aa0b1b85cf596b2135.1405417943.git.amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <339156532cdc68672d36d0aa0b1b85cf596b2135.1405417943.git.amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-2.1 1/1] virtio-serial-bus: keep
 port 0 reserved for virtconsole even on unplug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu list <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Amos Kong <akong@redhat.com>

On (Tue) 15 Jul 2014 [15:22:23], Amit Shah wrote:

> v2:
>  - move calculation of 'i' inside if stmt too (Paolo)
>  - re-word comment

> +    /*
> +     * Don't mark port 0 removed -- we explicitly reserve it for
> +     * backward compat with older guests, ensure a virtconsole device
> +     * unplug virtconsole retains the reservation.

oops, extra 'virtconsole'


		Amit