From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1X72lB-0000ku-Tv
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:27:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1X72l6-00026r-3D
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:27:09 -0400
Received: from afflict.kos.to ([92.243.29.197]:37144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1X72l5-00026I-Tz
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:27:04 -0400
Date: Tue, 15 Jul 2014 16:27:02 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20140715132702.GA607@afflict.kos.to>
References: <1405040522-29868-1-git-send-email-Joakim.Tjernlund@transmode.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1405040522-29868-1-git-send-email-Joakim.Tjernlund@transmode.se>
Subject: Re: [Qemu-devel] [PATCH] SIOCGIFINDEX: fix typo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org

On Fri, Jul 11, 2014 at 03:02:02AM +0200, Joakim Tjernlund wrote:
> Wrong type was used in ioctl definition.

Thanks, Applied to linux-user

> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> 
> However, this does not fix my dhcp problem:
> 
> jocke-ppc ~ # busybox udhcpc -v
> Adapter index 24
> MAC fe:22:44:22:55:77
> udhcpc (v1.21.0) started
> Executing /usr/share/udhcpc/default.script deconfig
> Setting IP address 0.0.0.0 on eth0
> Entering listen mode: raw
> Opening raw socket on ifindex 24
> Got raw socket fd
> udhcpc: bind: No such device
> jocke-ppc ~ # cat /sys/class/net/eth0/ifindex 
> 24
>  linux-user/ioctls.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 07a00da..609b27c 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -118,7 +118,7 @@
>    IOCTL(SIOCSIFMEM, IOC_W, MK_PTR(MK_STRUCT(STRUCT_ptr_ifreq)))
>    IOCTL(SIOCADDMULTI, IOC_W, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
>    IOCTL(SIOCDELMULTI, IOC_W, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
> -  IOCTL(SIOCGIFINDEX, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
> +  IOCTL(SIOCGIFINDEX, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_int_ifreq)))
>    IOCTL(SIOCSIFLINK, 0, TYPE_NULL)
>    IOCTL_SPECIAL(SIOCGIFCONF, IOC_W | IOC_R, do_ioctl_ifconf,
>                  MK_PTR(MK_STRUCT(STRUCT_ifconf)))
> -- 
> 1.8.5.5
>