From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7ErQ-00072k-Ic for qemu-devel@nongnu.org; Tue, 15 Jul 2014 22:22:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7ErH-0001YE-Hm for qemu-devel@nongnu.org; Tue, 15 Jul 2014 22:22:24 -0400 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:64021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7ErH-0001WW-AV for qemu-devel@nongnu.org; Tue, 15 Jul 2014 22:22:15 -0400 Received: by mail-pa0-f46.google.com with SMTP id lj1so380047pab.5 for ; Tue, 15 Jul 2014 19:22:14 -0700 (PDT) Date: Wed, 16 Jul 2014 10:22:20 +0800 From: Liu Yuan Message-ID: <20140716022220.GD15811@ubuntu-trusty> References: <1405406098-30981-1-git-send-email-namei.unix@gmail.com> <1405406098-30981-3-git-send-email-namei.unix@gmail.com> <53C51CF6.6070900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53C51CF6.6070900@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for quorum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org On Tue, Jul 15, 2014 at 06:22:14AM -0600, Eric Blake wrote: > On 07/15/2014 12:34 AM, Liu Yuan wrote: > > Cc: Eric Blake > > Signed-off-by: Liu Yuan > > --- > > qapi/block-core.json | 19 ++++++++++++++++++- > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > index e378653..22491bc 100644 > > --- a/qapi/block-core.json > > +++ b/qapi/block-core.json > > @@ -1384,6 +1384,18 @@ > > 'raw': 'BlockdevRef' } } > > > > ## > > +# @QuorumReadPattern > > +# An enumeration of quorum read pattern. > > s/pattern/patterns/ > > > +# > > +# @quorum: read all the children and do a quorum vote on reads > > +# > > +# @fifo: read a single child and try next child in FIFO order if read fails. > > Inconsistent on whether you are ending a line with '.'. I'm not quite > sure if this reads well; maybe: > > @fifo: read only from the first child that has not failed > > I also wonder if 'single' might be a better name than 'fifo', especially > if we later add a 'round-robin' for read load balancing. Both fifo and round-robin in our context indicate a single read. but either one looks okay to me. We need to reach agreement on the name before I send the next version, single or fifo or any other suggested, Benoit, Kevin, Stefan? Thanks Yuan