From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46747)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1X7EsR-0007v7-4T
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 22:23:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1X7EsI-0001sd-3g
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 22:23:27 -0400
Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:47458)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1X7EsH-0001sX-Sj
	for qemu-devel@nongnu.org; Tue, 15 Jul 2014 22:23:18 -0400
Received: by mail-pd0-f182.google.com with SMTP id fp1so364041pdb.13
	for <qemu-devel@nongnu.org>; Tue, 15 Jul 2014 19:23:16 -0700 (PDT)
Date: Wed, 16 Jul 2014 10:23:22 +0800
From: Liu Yuan <namei.unix@gmail.com>
Message-ID: <20140716022322.GE15811@ubuntu-trusty>
References: <1405406098-30981-1-git-send-email-namei.unix@gmail.com>
	<1405406098-30981-3-git-send-email-namei.unix@gmail.com>
	<53C51CF6.6070900@redhat.com>
	<20140716022220.GD15811@ubuntu-trusty>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140716022220.GD15811@ubuntu-trusty>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: add read-pattern support for
	quorum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Benoit Canet <benoit@irqsave.net>

On Wed, Jul 16, 2014 at 10:22:20AM +0800, Liu Yuan wrote:
> On Tue, Jul 15, 2014 at 06:22:14AM -0600, Eric Blake wrote:
> > On 07/15/2014 12:34 AM, Liu Yuan wrote:
> > > Cc: Eric Blake <eblake@redhat.com>
> > > Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> > > ---
> > >  qapi/block-core.json | 19 ++++++++++++++++++-
> > >  1 file changed, 18 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > > index e378653..22491bc 100644
> > > --- a/qapi/block-core.json
> > > +++ b/qapi/block-core.json
> > > @@ -1384,6 +1384,18 @@
> > >              'raw': 'BlockdevRef' } }
> > >  
> > >  ##
> > > +# @QuorumReadPattern
> > > +# An enumeration of quorum read pattern.
> > 
> > s/pattern/patterns/
> > 
> > > +#
> > > +# @quorum: read all the children and do a quorum vote on reads
> > > +#
> > > +# @fifo: read a single child and try next child in FIFO order if read fails.
> > 
> > Inconsistent on whether you are ending a line with '.'.  I'm not quite
> > sure if this reads well; maybe:
> > 
> > @fifo: read only from the first child that has not failed
> > 
> > I also wonder if 'single' might be a better name than 'fifo', especially
> > if we later add a 'round-robin' for read load balancing.
> 
> Both fifo and round-robin in our context indicate a single read.
> 
> but either one looks okay to me. We need to reach agreement on the name before I
> send the next version, single or fifo or any other suggested, Benoit, Kevin,
> Stefan?

Cc others mentioned.