Re: [Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

On Tue, Jul 15, 2014 at 05:21:21PM +0200, Paolo Bonzini wrote:
> Il 15/07/2014 16:37, Stefan Hajnoczi ha scritto:
> >>> This is of course missing here:
> >>>
> >>> 		break;
> >Let's keep goto restart so we don't use the BH for each completion
> >callback.  We just need the BH scheduled once to protect against the
> >deadlock.
> 
> Ah, I missed this remark.
> 
> Then you could add qemu_bh_cancel at the end of the BH handler.

No, because a worker thread could be completing a work item just as we
leave the BH handler.  Then the BH would be cancelled and the work item
completion would never get executed (until the next work item
completes).

This is why I needed the atomic completion_token.  That way I could
check whether more requests completed while we were in the BH handler.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]