From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7orE-0003FV-8F for qemu-devel@nongnu.org; Thu, 17 Jul 2014 12:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7or4-0000Kt-IO for qemu-devel@nongnu.org; Thu, 17 Jul 2014 12:48:36 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:50464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7or4-0000KU-Cr for qemu-devel@nongnu.org; Thu, 17 Jul 2014 12:48:26 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Jul 2014 12:48:25 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id B0FB338C804A for ; Thu, 17 Jul 2014 12:48:21 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp22035.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s6HGmDo65571014 for ; Thu, 17 Jul 2014 16:48:21 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s6HGlmnT012363 for ; Thu, 17 Jul 2014 12:47:49 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <53C7F06B.4080103@suse.de> References: <1404032955-2591-1-git-send-email-marcel.a@redhat.com> <20140629113701.GA26161@redhat.com> <1405606506.2696.60.camel@localhost.localdomain> <53C7DB9F.1060305@redhat.com> <53C7F06B.4080103@suse.de> Message-ID: <20140717164731.23073.74542@loki> Date: Thu, 17 Jul 2014 11:47:31 -0500 Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?q?Andreas_F=C3=A4rber?= , Paolo Bonzini , Marcel Apfelbaum , Peter Maydell Cc: qemu-devel@nongnu.org, aliguori@amazon.com, "Michael S. Tsirkin" Quoting Andreas F=C3=A4rber (2014-07-17 10:48:59) > Am 17.07.2014 16:20, schrieb Paolo Bonzini: > > Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: > >> On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: > >>> On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: > >>>> Replaced '_' with '-' to comply with QOM guidelines. > >>>> Made the conversion from HMP to QMP in vl.c > >>>> > >>>> Signed-off-by: Marcel Apfelbaum > >>> > >>> Nothing to do with me, pls merge through Andrea's or Paolo's tree. > >>> FWIW > >> Ping. > >> I thought we want this in 2.1 > > = > > Renaming properties is fine according to the QOM guidelines, so I think > > it can be left for 2.2. > > = > > Sorry for the delay, this patch escaped me completely. > = > Sorry, just seeing this patch now, too. > = > My argument for getting this into 2.1 had been to avoid tools picking up > these to-be-renamed property names from the start. At this point, I'm > not so sure whether it's worse to break management tools or potentially > some rarely used/tested option - if we decide for 2.2, is backporting to > 2.1.1 an option if we document it in the release notes? IMO, if there's some risk to breaking management or other tools, I'd rather it be left to major releases. And if these values are already misnam= ed for 2.1.0 and prior, I don't think we stop it from poliferating much more by pushing the fix up by a few months. I do think it makes sense to pull it in for 2.1.0-rc3, but I think that's a priority call and this seems fairly low risk. > = > Regards, > Andreas > = > -- = > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg