From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, maria.k@catit.be
Subject: Re: [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incompatible features
Date: Thu, 17 Jul 2014 19:27:03 +0100 [thread overview]
Message-ID: <20140717182703.GA25858@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1405590113-17052-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]
On Thu, Jul 17, 2014 at 11:41:53AM +0200, Kevin Wolf wrote:
> qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation
> would prevent feature table entries for bits 32-63 from being used, and
> it could assign errp multiple times if there was more than one unknown
> feature, resulting in an error_set() assertion failure.
>
> Fix the truncation, make sure to set the error exactly once and add a
> qemu-iotests case for it.
>
> This fixes https://bugs.launchpad.net/qemu/+bug/1342704/
>
> Reported-by: Maria Kustova <maria.k@catit.be>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 21 +++++++++++++-----
> tests/qemu-iotests/036 | 52 ++++++++++++++++++++++++++++++++++++++++++++-
> tests/qemu-iotests/036.out | 35 ++++++++++++++++++++++++++++++
> tests/qemu-iotests/qcow2.py | 15 ++++++++-----
> 4 files changed, 112 insertions(+), 11 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-07-17 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 9:41 [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incompatible features Kevin Wolf
2014-07-17 13:16 ` Eric Blake
2014-07-17 18:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717182703.GA25858@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=maria.k@catit.be \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).