From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1X7yZv-0006YD-RL
	for qemu-devel@nongnu.org; Thu, 17 Jul 2014 23:11:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1X7yZq-00035J-PF
	for qemu-devel@nongnu.org; Thu, 17 Jul 2014 23:11:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58380)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1X7yZq-00034v-GS
	for qemu-devel@nongnu.org; Thu, 17 Jul 2014 23:11:18 -0400
Date: Fri, 18 Jul 2014 11:11:31 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140718031131.GB2478@T430.redhat.com>
References: <1405597808-15975-1-git-send-email-namei.unix@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1405597808-15975-1-git-send-email-namei.unix@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] block/quorum: implement
 .bdrv_co_get_block_status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Benoit Canet <benoit@irqsave.net>

On Thu, 07/17 19:50, Liu Yuan wrote:
> - allow drive-mirror to create sprase mirror on images like qcow2
> - allow qemu-img map to work as expected on quorum driver
> 
> Cc: Benoit Canet <benoit@irqsave.net>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
>  block/quorum.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/block/quorum.c b/block/quorum.c
> index ebf5c71..f0d0a98 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -780,6 +780,21 @@ static coroutine_fn int quorum_co_flush(BlockDriverState *bs)
>      return result;
>  }
>  
> +static int64_t coroutine_fn quorum_co_get_block_status(BlockDriverState *bs,
> +                                                       int64_t sector_num,
> +                                                       int nb_sectors,
> +                                                       int *pnum)
> +{
> +    BDRVQuorumState *s = bs->opaque;
> +    BlockDriverState *child_bs = s->bs[0];

Should we consider other children?

Fam

> +
> +    if (child_bs->drv->bdrv_co_get_block_status)
> +        return child_bs->drv->bdrv_co_get_block_status(child_bs, sector_num,
> +                                                       nb_sectors, pnum);
> +
> +    return bdrv_get_block_status(child_bs, sector_num, nb_sectors, pnum);
> +}
> +