From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50821)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1X815I-0006PK-Vu
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 01:52:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1X815C-0005aj-W8
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 01:51:56 -0400
Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]:56901)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1X815C-0005ad-Og
	for qemu-devel@nongnu.org; Fri, 18 Jul 2014 01:51:50 -0400
Received: by mail-pd0-f170.google.com with SMTP id g10so4450830pdj.29
	for <qemu-devel@nongnu.org>; Thu, 17 Jul 2014 22:51:49 -0700 (PDT)
Date: Fri, 18 Jul 2014 13:52:02 +0800
From: Liu Yuan <namei.unix@gmail.com>
Message-ID: <20140718055202.GG15811@ubuntu-trusty>
References: <1405597808-15975-1-git-send-email-namei.unix@gmail.com>
	<20140718031131.GB2478@T430.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140718031131.GB2478@T430.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/quorum: implement
 .bdrv_co_get_block_status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Benoit Canet <benoit@irqsave.net>

On Fri, Jul 18, 2014 at 11:11:31AM +0800, Fam Zheng wrote:
> On Thu, 07/17 19:50, Liu Yuan wrote:
> > - allow drive-mirror to create sprase mirror on images like qcow2
> > - allow qemu-img map to work as expected on quorum driver
> > 
> > Cc: Benoit Canet <benoit@irqsave.net>
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> > ---
> >  block/quorum.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/block/quorum.c b/block/quorum.c
> > index ebf5c71..f0d0a98 100644
> > --- a/block/quorum.c
> > +++ b/block/quorum.c
> > @@ -780,6 +780,21 @@ static coroutine_fn int quorum_co_flush(BlockDriverState *bs)
> >      return result;
> >  }
> >  
> > +static int64_t coroutine_fn quorum_co_get_block_status(BlockDriverState *bs,
> > +                                                       int64_t sector_num,
> > +                                                       int nb_sectors,
> > +                                                       int *pnum)
> > +{
> > +    BDRVQuorumState *s = bs->opaque;
> > +    BlockDriverState *child_bs = s->bs[0];
> 
> Should we consider other children?
> 

No, other children are identical because we always do multiple sync writes
and at boot time we check the length.

Thanks
Yuan