* [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly @ 2014-07-12 3:17 Liu Yuan 2014-07-14 3:05 ` Fam Zheng 2014-07-14 3:06 ` Hu Tao 0 siblings, 2 replies; 5+ messages in thread From: Liu Yuan @ 2014-07-12 3:17 UTC (permalink / raw) To: qemu-devel; +Cc: Kevin Wolf Cc: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Liu Yuan <namei.unix@gmail.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 7dd43fd..78e7baf 100755 --- a/configure +++ b/configure @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then LIBS="$LIBS $libnfs_libs" else if test "$libnfs" = "yes" ; then - feature_not_found "libnfs" + feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3" fi libnfs="no" fi -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly 2014-07-12 3:17 [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly Liu Yuan @ 2014-07-14 3:05 ` Fam Zheng 2014-07-14 3:06 ` Hu Tao 1 sibling, 0 replies; 5+ messages in thread From: Fam Zheng @ 2014-07-14 3:05 UTC (permalink / raw) To: Liu Yuan; +Cc: Kevin Wolf, qemu-devel On Sat, 07/12 11:17, Liu Yuan wrote: > Cc: Kevin Wolf <kwolf@redhat.com> > Signed-off-by: Liu Yuan <namei.unix@gmail.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7dd43fd..78e7baf 100755 > --- a/configure > +++ b/configure > @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then > LIBS="$LIBS $libnfs_libs" > else > if test "$libnfs" = "yes" ; then > - feature_not_found "libnfs" > + feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3" I notice that other occasions of feature_not_found doesn't add "-" between package and devel. Fam ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly 2014-07-12 3:17 [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly Liu Yuan 2014-07-14 3:05 ` Fam Zheng @ 2014-07-14 3:06 ` Hu Tao 2014-07-15 14:16 ` Stefan Hajnoczi 1 sibling, 1 reply; 5+ messages in thread From: Hu Tao @ 2014-07-14 3:06 UTC (permalink / raw) To: Liu Yuan; +Cc: Kevin Wolf, qemu-devel On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote: > Cc: Kevin Wolf <kwolf@redhat.com> > Signed-off-by: Liu Yuan <namei.unix@gmail.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7dd43fd..78e7baf 100755 > --- a/configure > +++ b/configure > @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then > LIBS="$LIBS $libnfs_libs" > else > if test "$libnfs" = "yes" ; then > - feature_not_found "libnfs" > + feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3" > fi > libnfs="no" > fi > -- > 1.9.1 > I already had a patch that fixed all similar cases: http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg06411.html. Regards, Hu ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly 2014-07-14 3:06 ` Hu Tao @ 2014-07-15 14:16 ` Stefan Hajnoczi 2014-07-18 7:05 ` Liu Yuan 0 siblings, 1 reply; 5+ messages in thread From: Stefan Hajnoczi @ 2014-07-15 14:16 UTC (permalink / raw) To: Hu Tao; +Cc: Kevin Wolf, Liu Yuan, qemu-devel [-- Attachment #1: Type: text/plain, Size: 1112 bytes --] On Mon, Jul 14, 2014 at 11:06:08AM +0800, Hu Tao wrote: > On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote: > > Cc: Kevin Wolf <kwolf@redhat.com> > > Signed-off-by: Liu Yuan <namei.unix@gmail.com> > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 7dd43fd..78e7baf 100755 > > --- a/configure > > +++ b/configure > > @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then > > LIBS="$LIBS $libnfs_libs" > > else > > if test "$libnfs" = "yes" ; then > > - feature_not_found "libnfs" > > + feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3" > > fi > > libnfs="no" > > fi > > -- > > 1.9.1 > > > > I already had a patch that fixed all similar cases: > http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg06411.html. Thanks, I have applied Hu's patch to my block-next tree because it includes this and other cases. Please CC me on block layer patches. I co-maintain the block layer with Kevin and am merging patches this week. Stefan [-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly 2014-07-15 14:16 ` Stefan Hajnoczi @ 2014-07-18 7:05 ` Liu Yuan 0 siblings, 0 replies; 5+ messages in thread From: Liu Yuan @ 2014-07-18 7:05 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: Kevin Wolf, Hu Tao, qemu-devel On Tue, Jul 15, 2014 at 04:16:14PM +0200, Stefan Hajnoczi wrote: > On Mon, Jul 14, 2014 at 11:06:08AM +0800, Hu Tao wrote: > > On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote: > > > Cc: Kevin Wolf <kwolf@redhat.com> > > > Signed-off-by: Liu Yuan <namei.unix@gmail.com> > > > --- > > > configure | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/configure b/configure > > > index 7dd43fd..78e7baf 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then > > > LIBS="$LIBS $libnfs_libs" > > > else > > > if test "$libnfs" = "yes" ; then > > > - feature_not_found "libnfs" > > > + feature_not_found "libnfs" "Install libnfs-devel >= 1.9.3" > > > fi > > > libnfs="no" > > > fi > > > -- > > > 1.9.1 > > > > > > > I already had a patch that fixed all similar cases: > > http://lists.nongnu.org/archive/html/qemu-devel/2014-06/msg06411.html. > > Thanks, I have applied Hu's patch to my block-next tree because it > includes this and other cases. > > Please CC me on block layer patches. I co-maintain the block layer with > Kevin and am merging patches this week. Umm, I git log see that this file related to block layer mostly sent to kevin, so I thought I should only send it to Kevin. I'll include you from this time on as I did before. Yuan ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-18 7:05 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-12 3:17 [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly Liu Yuan 2014-07-14 3:05 ` Fam Zheng 2014-07-14 3:06 ` Hu Tao 2014-07-15 14:16 ` Stefan Hajnoczi 2014-07-18 7:05 ` Liu Yuan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).