From: Amit Shah <amit.shah@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
mtosatti@redhat.com, qemu-devel@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation"
Date: Fri, 18 Jul 2014 17:15:41 +0530 [thread overview]
Message-ID: <20140718114541.GB26614@grmbl.mre> (raw)
In-Reply-To: <53C906AF.6060407@suse.de>
On (Fri) 18 Jul 2014 [13:36:15], Alexander Graf wrote:
>
> On 18.07.14 13:31, Amit Shah wrote:
> >On (Fri) 18 Jul 2014 [11:04:24], Paolo Bonzini wrote:
> >>This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56.
> >>
> >>Cc: agraf@suse.de
> >>Cc: mtosatti@redhat.com
> >>Cc: qemu-stable@nongnu.org
> >>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >Please include some information on why this is being reverted. Helps
> >people browsing the tree later.
>
> Yeah, I'm also not convinced it's a great idea to trade one known bug with
> another known bug.
I'm not opposed to the revert, though. We don't yet have a fix for
the issue caused by the original patch, and Paolo is being
conservative in keeping the older bug around for 2.1, rather than
trading it for unknown bugs at this stage.
The investigation for the bug is proceeding, though, and we may get a
fix soon. If it turns out to be well-contained, we could also look at
backporting all the fixes to -stable, if it helps.
Amit
next prev parent reply other threads:[~2014-07-18 11:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:04 [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18 Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700 Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 3/6] module: Simplify module_load() Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent Paolo Bonzini
2014-07-18 13:48 ` Michael Tokarev
2014-07-18 9:04 ` [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation" Paolo Bonzini
2014-07-18 11:31 ` Amit Shah
2014-07-18 11:36 ` Alexander Graf
2014-07-18 11:45 ` Amit Shah [this message]
2014-07-18 9:04 ` [Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward" Paolo Bonzini
2014-07-18 12:46 ` [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18 Peter Maydell
2014-07-18 12:55 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-07-18 13:31 [Qemu-devel] [PULL v2 " Paolo Bonzini
2014-07-18 13:31 ` [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation" Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718114541.GB26614@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=agraf@suse.de \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).