[Qemu-devel] [PATCH] docs: Make the recommendation for the backing file name position a requirement

[Qemu-devel] [PATCH] docs: Make the recommendation for the backing file name position a requirement

[Maria Kustova]

The current version of the qcow2 specification recommends to save the backing
file name in the end of the first cluster. It follows that the backing file
name can be saved somewhere in the image, but the first cluster, which
contradicts the current QEMU implementation.

The patch makes the backing file name required to be placed after the header
extensions in the first image cluster.

Signed-off-by: Maria Kustova <maria.k@catit.be>
---
 docs/specs/qcow2.txt | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 3f713a6..cfbc8b0 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -135,12 +135,12 @@ be stored. Each extension has a structure like the following:
 Unless stated otherwise, each header extension type shall appear at most once
 in the same image.
 
-The remaining space between the end of the header extension area and the end of
-the first cluster can be used for the backing file name. It is not allowed to
-store other data here, so that an implementation can safely modify the header
-and add extensions without harming data of compatible features that it
-doesn't support. Compatible features that need space for additional data can
-use a header extension.
+If the image has a backing file then the backing file name should be stored in
+the remaining space between the end of the header extension area and the end of
+the first cluster. It is not allowed to store other data here, so that an
+implementation can safely modify the header and add extensions without harming
+data of compatible features that it doesn't support. Compatible features that
+need space for additional data can use a header extension.
 
 
 == Feature name table ==
-- 
1.9.3

Re: [Qemu-devel] [PATCH] docs: Make the recommendation for the backing file name position a requirement

[Kevin Wolf]

Am 21.07.2014 um 13:16 hat Maria Kustova geschrieben:
> The current version of the qcow2 specification recommends to save the backing
> file name in the end of the first cluster. It follows that the backing file
> name can be saved somewhere in the image, but the first cluster, which
> contradicts the current QEMU implementation.
> 
> The patch makes the backing file name required to be placed after the header
> extensions in the first image cluster.
> 
> Signed-off-by: Maria Kustova <maria.k@catit.be>

Thanks, applied to the block-next branch.

This is how it was always meant, but your wording is clearer.

Kevin