From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1X9Es0-00071L-GP
	for qemu-devel@nongnu.org; Mon, 21 Jul 2014 10:47:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1X9Erv-0002jt-3E
	for qemu-devel@nongnu.org; Mon, 21 Jul 2014 10:47:16 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:49747)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samuel.thibault@ens-lyon.org>) id 1X9Eru-0002jc-TD
	for qemu-devel@nongnu.org; Mon, 21 Jul 2014 10:47:11 -0400
Date: Mon, 21 Jul 2014 16:47:09 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20140721144709.GA5390@type.bordeaux.inria.fr>
References: <CACaajQu8yPh7xeh2tukQbvWYfVcUpi1=rHXg7BsmXobBv4easw@mail.gmail.com>
	<20140721114146.GT5390@type.bordeaux.inria.fr>
	<CACaajQu0bT5hXKSfLMtgTTauzmyKa59TgNSjn3oXdaUAH5iB8A@mail.gmail.com>
	<20140721114911.GU5390@type.bordeaux.inria.fr>
	<CACaajQtprOs3bWWOFzgb7i+auQr98KMeQWw3nvcXGWrCTLj1sQ@mail.gmail.com>
	<CACaajQvyRYBgKy9WobRMOy2nDjgE-b0z6Oezcfzf4Du9Ww7YGQ@mail.gmail.com>
	<20140721120643.GV5390@type.bordeaux.inria.fr>
	<CACaajQv8PNAmpPEt=8n75zahOzsDGO6WbwLz7LUxfap=TfVhXg@mail.gmail.com>
	<20140721142934.GZ5390@type.bordeaux.inria.fr>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="3V7upXqbjpZ4EhLz"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20140721142934.GZ5390@type.bordeaux.inria.fr>
Subject: Re: [Qemu-devel] ipv6 slirp network
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vasiliy Tolstov <v.tolstov@selfip.ru>
Cc: libvir-list@redhat.com, QEMU <qemu-devel@nongnu.org>


--3V7upXqbjpZ4EhLz
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Samuel Thibault, le Mon 21 Jul 2014 16:29:34 +0200, a écrit :
> Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit :
> > 2014-07-21 16:06 GMT+04:00 Samuel Thibault <samuel.thibault@gnu.org>:
> > > I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in
> > > the tosubmit branch.
> > 
> > 
> > Inside packer (i'm try to build some centos 7 boxes) i have errors
> > Qemu stderr: qemu-system-x86_64: slirp/tcp_input.c:1543: tcp_mss:
> > Assertion `0' failed.
> 
> Uh?!  Does the switch statement properly have both AF_INET and AF_INET6
> cases?
> 
> A gdb backtrace would also be useful.

Mmm, I guess this is coming through tcp_connect().  Could you try the
attached patch?

Samuel

--3V7upXqbjpZ4EhLz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch

diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c
index a1f060b..feae861 100644
--- a/slirp/tcp_subr.c
+++ b/slirp/tcp_subr.c
@@ -439,6 +439,7 @@ void tcp_connect(struct socket *inso)
             return;
         }
         so->lhost = inso->lhost;
+        so->ffamily = inso->so_ffamily;
     }
 
     tcp_mss(sototcpcb(so), 0);

--3V7upXqbjpZ4EhLz--