From: Stefan Hajnoczi <stefanha@gmail.com>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend
Date: Tue, 22 Jul 2014 13:35:20 +0100 [thread overview]
Message-ID: <20140722123520.GA21042@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1403857452-23768-2-git-send-email-cnanakos@grnet.gr>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote:
> + xseg_set_req_data(s->xseg, req, reqdata);
> + if (op == ARCHIP_OP_WRITE) {
> + data = xseg_get_data(s->xseg, req);
> + if (!data) {
> + archipelagolog("Cannot get XSEG data\n");
> + goto err_exit;
> + }
> + memcpy(data, aio_cb->buffer + bufidx, count);
> + }
Can you avoid ->buffer and use iov_to_buf() or qemu_iovec_to_buf()
instead?
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-07-22 12:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 8:24 [Qemu-devel] [PATCH v6 0/5] Support Archipelago as a QEMU block backend Chrysostomos Nanakos
2014-06-27 8:24 ` [Qemu-devel] [PATCH v6 1/5] block: " Chrysostomos Nanakos
2014-07-02 13:59 ` Eric Blake
2014-07-02 14:18 ` Chrysostomos Nanakos
2014-07-02 14:30 ` Eric Blake
2014-07-10 0:23 ` Jeff Cody
2014-07-10 10:04 ` Chrysostomos Nanakos
2014-07-10 14:02 ` Chrysostomos Nanakos
2014-07-22 12:40 ` Stefan Hajnoczi
2014-07-22 12:35 ` Stefan Hajnoczi [this message]
2014-06-27 8:24 ` [Qemu-devel] [PATCH v6 2/5] block/archipelago: Implement bdrv_parse_filename() Chrysostomos Nanakos
2014-07-21 15:55 ` Stefan Hajnoczi
2014-06-27 8:24 ` [Qemu-devel] [PATCH v6 3/5] block/archipelago: Add support for creating images Chrysostomos Nanakos
2014-07-02 14:01 ` Eric Blake
2014-07-02 14:06 ` Chrysostomos Nanakos
2014-07-21 16:01 ` Stefan Hajnoczi
2014-06-27 8:24 ` [Qemu-devel] [PATCH v6 4/5] QMP: Add support for Archipelago Chrysostomos Nanakos
2014-07-02 13:58 ` Eric Blake
2014-07-02 14:11 ` Chrysostomos Nanakos
2014-07-02 14:22 ` Eric Blake
2014-06-27 8:24 ` [Qemu-devel] [PATCH v6 5/5] qemu-iotests: add support for Archipelago protocol Chrysostomos Nanakos
2014-07-21 16:02 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722123520.GA21042@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=cnanakos@grnet.gr \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).