From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9ZI5-0005GI-RL for qemu-devel@nongnu.org; Tue, 22 Jul 2014 08:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9ZHw-0002ft-HF for qemu-devel@nongnu.org; Tue, 22 Jul 2014 08:35:33 -0400 Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:36606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9ZHw-0002fc-AJ for qemu-devel@nongnu.org; Tue, 22 Jul 2014 08:35:24 -0400 Received: by mail-wg0-f46.google.com with SMTP id m15so7986790wgh.5 for ; Tue, 22 Jul 2014 05:35:23 -0700 (PDT) Date: Tue, 22 Jul 2014 13:35:20 +0100 From: Stefan Hajnoczi Message-ID: <20140722123520.GA21042@stefanha-thinkpad.redhat.com> References: <1403857452-23768-1-git-send-email-cnanakos@grnet.gr> <1403857452-23768-2-git-send-email-cnanakos@grnet.gr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <1403857452-23768-2-git-send-email-cnanakos@grnet.gr> Subject: Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chrysostomos Nanakos Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote: > + xseg_set_req_data(s->xseg, req, reqdata); > + if (op == ARCHIP_OP_WRITE) { > + data = xseg_get_data(s->xseg, req); > + if (!data) { > + archipelagolog("Cannot get XSEG data\n"); > + goto err_exit; > + } > + memcpy(data, aio_cb->buffer + bufidx, count); > + } Can you avoid ->buffer and use iov_to_buf() or qemu_iovec_to_buf() instead? --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTzlqIAAoJEJykq7OBq3PIql8IAMi6j0hvHIR+MicJgmkucWd3 F9Ed2ydFyJbhZohx1z/9CF02ROPngLhL+MRIEpmiY+YYn+/8sPnmZ3EBh8ZmRy6s +XmH43+B3kbadGHMmsSIDOk2D2G8MZvrYGPiGw3TKZPCXyFpr5WPcMJSS9i4mMxs kMVokHRqdKo36fK5VQuKFzWK/NUgr7T504E6Gi2JxGlEABHhkUtDlOnxWeiDAJjk Y650scFCtRmjqkw4pfqPsmrT44eqK8jN+loniJuDezATcdQ6sWIo7D+gGGVch+kQ hvIhRRObwHj2AU3Hbj9C7Q2ERuJkcMvxM5dJMEcmKcEYBJ4qXc4WU7fBOMFWMUU= =fxCG -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--