Re: [Qemu-devel] Live migrate, inconsistent machine types - new machine type to fix?

[Amit Shah <amit.shah@redhat.com>]

On (Tue) 22 Jul 2014 [13:15:41], Alex Bligh wrote:
> 
> On 22 Jul 2014, at 12:54, Amit Shah <amit.shah@redhat.com> wrote:
> 
> > Sigh; please read both my replies.
> > 
> > The only difference between qemu-kvm-1.0 and qemu-1.0 is the presence
> > of the pci-assign section in qemu-kvm-1.0.  All other output from
> > qemu-1.0 -> qemu-2.1 is equally applicable to qemu-kvm-1.0 ->
> > qemu-2.1.
> ...
> > I know that; but you brought up the comparison of your experiments
> > with the output of the checker.  I just pointed out the checker
> > flagged both those things you saw (and a few others too).
> 
> Apologies for my naivety here as it's the first time I've looked
> at this stuff. So sorry if I'm getting the wrong end of the stick.
> 
> However, am I correct in assuming your JSON checker is only
> checking for the field structure, and not for things like
> changed defaults?

It only looks at the vmstate structs.

> For instance the cirrus vga video ram size
> appears to be different between qemu-kvm-1.0 and qemu-1.0,

Right, this won't get flagged.

> but this isn't something brought up in your email highlighting
> the difference between a 2.1->qemu-1.0 comparison and a
> 2.1->qemu-kvm-1.0 comparison. I know you haven't directly
> compared qemu-1.0 and qemu-1.0-kvm, but if this difference
> does exist (which I think it does) I'd expect to see it
> in the list of differences (i.e. your second email), if your
> tool looks at that too.

I did compare qemu-1.0 and qemu-kvm-1.0, but this difference won't pop
up.

The other differences that the checker spotted may not be relevant to
you, as your VMs don't have those devices enabled.

		Amit