qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] block/parallels: split check for parallels format in parallels_open
Date: Thu, 24 Jul 2014 14:50:34 -0400	[thread overview]
Message-ID: <20140724185034.GC24801@localhost.localdomain> (raw)
In-Reply-To: <1406035177-221890-4-git-send-email-den@openvz.org>

On Tue, Jul 22, 2014 at 05:19:36PM +0400, Denis V. Lunev wrote:
> and rework error path a bit. There is no difference at the moment, but
> the code will be definitely shorter when additional processing will
> be required for WithouFreSpacExt
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/parallels.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/block/parallels.c b/block/parallels.c
> index 8f9ec8a..02739cf 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -85,12 +85,10 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
>          goto fail;
>      }
>  
> -    if (memcmp(ph.magic, HEADER_MAGIC, 16) ||
> -        (le32_to_cpu(ph.version) != HEADER_VERSION)) {
> -        error_setg(errp, "Image not in Parallels format");
> -        ret = -EINVAL;
> -        goto fail;
> -    }
> +    if (le32_to_cpu(ph.version) != HEADER_VERSION)
> +        goto fail_format;
> +    if (memcmp(ph.magic, HEADER_MAGIC, 16))
> +        goto fail_format;

QEMU coding style dictates these statements have curly braces, even
though they are just one liners.  (If you run your patches against
scripts/checkpatch.pl, it should catch most style issues).

I think this patch could also just be squashed into patch 4, if
desired.

>  
>      bs->total_sectors = (uint32_t)le64_to_cpu(ph.nb_sectors);
>  
> @@ -120,6 +118,9 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
>      qemu_co_mutex_init(&s->lock);
>      return 0;
>  
> +fail_format:
> +    error_setg(errp, "Image not in Parallels format");
> +    ret = -EINVAL;
>  fail:
>      g_free(s->catalog_bitmap);
>      return ret;
> -- 
> 1.9.1
> 
> 

  reply	other threads:[~2014-07-24 18:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 13:19 [Qemu-devel] [PATCH 0/4] block/parallels: 2TB+ parallels images support Denis V. Lunev
2014-07-22 13:19 ` [Qemu-devel] [PATCH 1/4] block/parallels: extend parallels format header with actual data values Denis V. Lunev
2014-07-24 18:34   ` Jeff Cody
2014-07-25  3:33     ` Denis V. Lunev
2014-07-22 13:19 ` [Qemu-devel] [PATCH 2/4] block/parallels: replace tabs with spaces in block/parallels.c Denis V. Lunev
2014-07-24 18:36   ` Jeff Cody
2014-07-22 13:19 ` [Qemu-devel] [PATCH 3/4] block/parallels: split check for parallels format in parallels_open Denis V. Lunev
2014-07-24 18:50   ` Jeff Cody [this message]
2014-07-25  3:36     ` Denis V. Lunev
2014-07-22 13:19 ` [Qemu-devel] [PATCH 4/4] block/parallels: 2TB+ parallels images support Denis V. Lunev
2014-07-24 19:25   ` Jeff Cody
2014-07-25  3:51     ` Denis V. Lunev
2014-07-25 13:08       ` Jeff Cody
2014-07-25 13:12         ` Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140724185034.GC24801@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).