From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAi57-0007nF-A5 for qemu-devel@nongnu.org; Fri, 25 Jul 2014 12:11:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAi50-0002SL-MK for qemu-devel@nongnu.org; Fri, 25 Jul 2014 12:10:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAi50-0002SF-Cz for qemu-devel@nongnu.org; Fri, 25 Jul 2014 12:10:46 -0400 Date: Fri, 25 Jul 2014 17:10:40 +0100 From: Stefan Hajnoczi Message-ID: <20140725161040.GG1855@stefanha-thinkpad.redhat.com> References: <1406226665-1710-1-git-send-email-marc.mari.barcelo@gmail.com> <1406226665-1710-8-git-send-email-marc.mari.barcelo@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JbKQpFqZXJ2T76Sg" Content-Disposition: inline In-Reply-To: <1406226665-1710-8-git-send-email-marc.mari.barcelo@gmail.com> Subject: Re: [Qemu-devel] [PATCH 7/7] libqos: Added basic virtqueue support to virtio implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc =?iso-8859-1?Q?Mar=ED?= Cc: Paolo Bonzini , qemu-devel@nongnu.org --JbKQpFqZXJ2T76Sg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 24, 2014 at 08:31:05PM +0200, Marc Mar=ED wrote: > +static void qvirtio_pci_set_queue_address(QVirtioDevice *d, uint16_t add= r) > +{ > + QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d; > + qpci_io_writel(dev->pdev, dev->addr + QVIRTIO_QUEUE_ADDRESS, addr); > +} Why is addr uint16_t? It should be a 32-bit Page Frame Number). It's probably clearer to name it "pfn" instead of "addr" since it's not an address. --JbKQpFqZXJ2T76Sg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT0oGAAAoJEJykq7OBq3PIQdAH/3kqd7ZyI3mEVDYxfD3/dAIb Prsyu88s66AyDLfbub9sdwo+/LdOD15NSm7fibS8rZYsW0IFF3DAbFcKjCzL//eV y2pM9v6PhYfo5AkDRe2plqd9bZVJUsSCiTfnvdJtuXASdeVOLogvHqY38oWHJBDZ 3F6vkDLDZGPzUvM4FZQOk9sJUJ6v1iAIPwFmtPfKAM+F8EsmWK+i3X0hL3aB0mfC 887qsnGPqSzkeQmgqGP/MpgSld351jGmhNBnN0shwroUYJ/IEOcq+gKb/GZ82fy2 +kZVFqR5xVuMW7KEtwOa1f40+F7oqQHbKQQFYiHc41R9GETGOkauoGoJTriFbiE= =D2SB -----END PGP SIGNATURE----- --JbKQpFqZXJ2T76Sg--