From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47373)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marc.mari.barcelo@gmail.com>) id 1XAish-0003OM-Jc
	for qemu-devel@nongnu.org; Fri, 25 Jul 2014 13:02:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marc.mari.barcelo@gmail.com>) id 1XAisY-0000tK-JH
	for qemu-devel@nongnu.org; Fri, 25 Jul 2014 13:02:07 -0400
Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:61243)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marc.mari.barcelo@gmail.com>) id 1XAisY-0000s1-DT
	for qemu-devel@nongnu.org; Fri, 25 Jul 2014 13:01:58 -0400
Received: by mail-wg0-f43.google.com with SMTP id l18so4333198wgh.26
	for <qemu-devel@nongnu.org>; Fri, 25 Jul 2014 10:01:55 -0700 (PDT)
Date: Fri, 25 Jul 2014 19:01:47 +0200
From: Marc =?UTF-8?B?TWFyw60=?= <marc.mari.barcelo@gmail.com>
Message-ID: <20140725190147.36e605f9@crunchbang>
In-Reply-To: <20140725151941.GC1855@stefanha-thinkpad.redhat.com>
References: <1406226665-1710-1-git-send-email-marc.mari.barcelo@gmail.com>
	<1406226665-1710-3-git-send-email-marc.mari.barcelo@gmail.com>
	<20140725151941.GC1855@stefanha-thinkpad.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

El Fri, 25 Jul 2014 16:19:41 +0100
Stefan Hajnoczi <stefanha@redhat.com> escribi=C3=B3:
> On Thu, Jul 24, 2014 at 08:31:00PM +0200, Marc Mar=C3=AD wrote:
> > +static uint32_t qvirtio_pci_get_features(QVirtioDevice *d)
> > +{
> > +    QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d;
> > +    return qpci_io_readl(dev->pdev, dev->addr +
> > QVIRTIO_DEVICE_FEATURES); +}
>=20
> Unused?  If it's unused, then it's untested.

Yes, moved to the other patch for v2

>=20
> > +
> > +static uint8_t qvirtio_pci_get_status(QVirtioDevice *d)
> > +{
> > +    QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d;
> > +    return qpci_io_readb(dev->pdev, dev->addr +
> > QVIRTIO_DEVICE_STATUS); +}
>=20
> Unused?

Used in virtio.c (qvirtio_reset / qvirtio_set_acknowledge /
qvirtio_set_driver).

=20
> > +
> > +static void qvirtio_pci_set_status(QVirtioDevice *d, uint8_t val)
> > +{
> > +    QVirtioPCIDevice *dev =3D (QVirtioPCIDevice *)d;
> > +    qpci_io_writeb(dev->pdev, dev->addr + QVIRTIO_DEVICE_STATUS,
> > val);
>=20
> Unused?

Also in virtio.c

>=20
> > @@ -73,3 +97,11 @@ QVirtioPCIDevice
> > *qvirtio_pci_device_find(QPCIBus *bus, uint16_t device_type)=20
> >      return dev;
> >  }
> > +
> > +void qvirtio_pci_enable_device(QVirtioPCIDevice *d)
> > +{
> > +    qpci_device_enable(d->pdev);
> > +    d->addr =3D qpci_iomap(d->pdev, 0);
> > +    g_assert(d->addr !=3D NULL);
> > +}
>=20
> Where is qpci_iounmap() called to clean up?

Missed. Also, it is unimplemented.
Marc