From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBh87-0004SB-5Q for qemu-devel@nongnu.org; Mon, 28 Jul 2014 05:22:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBh7z-0006hR-MK for qemu-devel@nongnu.org; Mon, 28 Jul 2014 05:22:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBh7z-0006h9-E7 for qemu-devel@nongnu.org; Mon, 28 Jul 2014 05:21:55 -0400 Date: Mon, 28 Jul 2014 10:21:51 +0100 From: Stefan Hajnoczi Message-ID: <20140728092151.GB13872@stefanha-thinkpad.redhat.com> References: <1406226665-1710-1-git-send-email-marc.mari.barcelo@gmail.com> <1406226665-1710-3-git-send-email-marc.mari.barcelo@gmail.com> <20140725151941.GC1855@stefanha-thinkpad.redhat.com> <20140725190147.36e605f9@crunchbang> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LyciRD1jyfeSSjG0" Content-Disposition: inline In-Reply-To: <20140725190147.36e605f9@crunchbang> Subject: Re: [Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc =?iso-8859-1?Q?Mar=ED?= Cc: Paolo Bonzini , qemu-devel@nongnu.org --LyciRD1jyfeSSjG0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 25, 2014 at 07:01:47PM +0200, Marc Mar=ED wrote: > > > @@ -73,3 +97,11 @@ QVirtioPCIDevice > > > *qvirtio_pci_device_find(QPCIBus *bus, uint16_t device_type)=20 > > > return dev; > > > } > > > + > > > +void qvirtio_pci_enable_device(QVirtioPCIDevice *d) > > > +{ > > > + qpci_device_enable(d->pdev); > > > + d->addr =3D qpci_iomap(d->pdev, 0); > > > + g_assert(d->addr !=3D NULL); > > > +} > >=20 > > Where is qpci_iounmap() called to clean up? >=20 > Missed. Also, it is unimplemented. It would be much harder to add in the appropriate guest_free() calls later so users should still call it. Just like we should call guest_free() even if it is currently unimplemented. Stefan --LyciRD1jyfeSSjG0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT1hYvAAoJEJykq7OBq3PI7OkH/1UvQApv2Hz3Q1FqDD77D0pA JJCwuzASHRpSGj4i50mfo/YYa5QsKXR+QrFzlxd/w5vWVm6gAdPmFZlsR+IdDst3 SpcYW32DxmsGqBwCJuzvgj/SSKUYRVasCXyFQQR5bRDR72PifKd+1W1dntIdDHaK J9QQn4xfs2g0RW1yl3amdS2xR0iUNsra6wGTDypvSSfCOxmZ7sFEj77GoFrm3E7T OhTJDo564xK4OP7EtOxAmk16QwKnkGmEOy2xPPt5UFoGMclYZn18HCcx0tQEyYWr JmX5/ImUW/3kEGpSW7TRcaraUN3h/X4yoPlRAKw1s/8rGzbu6Mtl/+2PwFLClzk= =2He4 -----END PGP SIGNATURE----- --LyciRD1jyfeSSjG0--