From: Igor Mammedov <imammedo@redhat.com>
To: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-i386/cpu.c: Fix two error output indentation
Date: Mon, 28 Jul 2014 10:07:33 +0200 [thread overview]
Message-ID: <20140728100733.195b41a1@nial.usersys.redhat.com> (raw)
In-Reply-To: <1406531586-17653-1-git-send-email-chen.fan.fnst@cn.fujitsu.com>
On Mon, 28 Jul 2014 15:13:06 +0800
Chen Fan <chen.fan.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> ---
> target-i386/cpu.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 6d008ab..217500c 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1716,9 +1716,9 @@ static void x86_set_hv_spinlocks(Object *obj, Visitor *v, void *opaque,
>
> if (value < min || value > max) {
> error_setg(errp, "Property %s.%s doesn't take value %" PRId64
> - " (minimum: %" PRId64 ", maximum: %" PRId64 ")",
> - object_get_typename(obj), name ? name : "null",
> - value, min, max);
> + " (minimum: %" PRId64 ", maximum: %" PRId64 ")",
> + object_get_typename(obj), name ? name : "null",
> + value, min, max);
> return;
> }
> cpu->hyperv_spinlock_attempts = value;
> @@ -1808,8 +1808,8 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char *features,
> }
> if (numvalue < min) {
> error_report("hv-spinlocks value shall always be >= 0x%x"
> - ", fixup will be removed in future versions",
> - min);
> + ", fixup will be removed in future versions",
> + min);
> numvalue = min;
> }
> snprintf(num, sizeof(num), "%" PRId32, numvalue);
CCed qemu-trivial@nongnu.org
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
next prev parent reply other threads:[~2014-07-28 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 7:13 [Qemu-devel] [PATCH] target-i386/cpu.c: Fix two error output indentation Chen Fan
2014-07-28 8:07 ` Igor Mammedov [this message]
2014-08-02 13:23 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728100733.195b41a1@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).