From: Aurelien Jarno <aurelien@aurel32.net>
To: Dongxue Zhang <elta.era@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] target-mips/translate.c: Free TCG in OPC_DINSV
Date: Mon, 28 Jul 2014 23:42:30 +0200 [thread overview]
Message-ID: <20140728214230.GA24651@ohm.rr44.fr> (raw)
In-Reply-To: <1406563102-11035-1-git-send-email-elta.era@gmail.com>
On Mon, Jul 28, 2014 at 11:58:21PM +0800, Dongxue Zhang wrote:
> Free t0 and t1 in opcode OPC_DINSV.
>
> Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
> ---
> target-mips/translate.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index d7b8c4d..c381366 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -15300,6 +15300,9 @@ static void decode_opc (CPUMIPSState *env, DisasContext *ctx)
> gen_load_gpr(t1, rs);
>
> gen_helper_dinsv(cpu_gpr[rt], cpu_env, t1, t0);
> +
> + tcg_temp_free(t0);
> + tcg_temp_free(t1);
> break;
> }
> default: /* Invalid */
Good catch, I applied the patch.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2014-07-28 21:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 15:58 [Qemu-devel] [PATCH 1/2] target-mips/translate.c: Free TCG in OPC_DINSV Dongxue Zhang
2014-07-28 15:58 ` [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb Dongxue Zhang
2014-07-28 21:42 ` Aurelien Jarno
2014-07-28 22:01 ` Peter Maydell
2014-07-28 22:32 ` Aurelien Jarno
2014-07-28 22:34 ` Peter Maydell
2014-07-28 22:52 ` Aurelien Jarno
2014-07-29 12:41 ` Elta
2014-07-29 14:08 ` Aurelien Jarno
2014-07-29 15:32 ` Dongxue Zhang
2014-07-29 12:47 ` Peter Maydell
2014-07-28 21:42 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728214230.GA24651@ohm.rr44.fr \
--to=aurelien@aurel32.net \
--cc=elta.era@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).