From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC7WD-00065T-MQ for qemu-devel@nongnu.org; Tue, 29 Jul 2014 09:32:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC7W8-0001ca-7u for qemu-devel@nongnu.org; Tue, 29 Jul 2014 09:32:41 -0400 Date: Tue, 29 Jul 2014 14:32:30 +0100 From: Stefan Hajnoczi Message-ID: <20140729133230.GA26947@stefanha-thinkpad.redhat.com> References: <1404907292-20442-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <1404907292-20442-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device properties in -device FOO, help output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Markus Armbruster , qemu-stable@nongnu.org, qemu-devel@nongnu.org, Andreas Faerber , crobinso@redhat.com --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 09, 2014 at 02:01:30PM +0200, Stefan Hajnoczi wrote: > These two patches fix the -device FOO,help output regression that Cole sp= otted > in QEMU 2.0-rc0. The problem is that virtio-blk-pci qdev properties have= been > converted to QOM alias properties but -device FOO,help shows only qdev > properties. >=20 > We simply need to update -device FOO,help code to use both qdev and QOM > properties. Note that types change because a 'drive' qdev type is actual= ly a > 'str' QOM type. We're moving more and more to QOM properties where the f= inal > type for this property would be 'link' or similar. >=20 > Cole: please confirm that this fixes the issue >=20 > Stefan Hajnoczi (2): > qmp: hide "hotplugged" device property from device-list-properties > qdev-monitor: include QOM properties in -device FOO,help output >=20 > qdev-monitor.c | 40 +++++++++++++++++----------------------- > qmp.c | 1 + > 2 files changed, 18 insertions(+), 23 deletions(-) CCed qemu-stable since we ought to fix -device FOO,?. This patch was missed for QEMU 2.1 but not critical (see Cole's response). Applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT16JuAAoJEJykq7OBq3PI8eQH/i/iWwvPVDAwhLQXvjkofujS ua17ARtknt3aVtFkHc5mvvCR8xuTjjmCVINympmjuBermUVeiM7nQdoA7/gzZ/RD 2x7odJsEJWlo74l71khfV9DS08PKaIhz4XnfxiPEK1cxwVGeOrPG2MeS/bFHHGOh lAzONgbVVjNZPUnoJ6E1TMWTPioSkCHHt+JcJSz9lm+YeyC8+YpwQaF4lnCOVb4K 9y58+64PlX5QOF60tEWBaaH9Loc8XeZdPAYNFXuMebc9Vj/2VKGiyZ/q2os4ZGqt lnhS3OYNGV+AzGuFKrVewE7fB0BgeNYCP43wKR1H0ki3ua62czxwzSpEKgL39tM= =tnFN -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn--