Re: [Qemu-devel] [PATCH for 2.1 V3] qemu-img info: show nocow info

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

On Mon, Jul 28, 2014 at 12:58:33PM -0600, Eric Blake wrote:
> On 07/28/2014 09:19 AM, Stefan Hajnoczi wrote:
> > On Wed, Jul 09, 2014 at 10:43:13AM +0800, Chunyan Liu wrote:
> >> Add nocow info in 'qemu-img info' output to show whether the file
> >> currently has NOCOW flag set or not.
> >>
> >> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> >> ---
> >> Changes:
> >>   - update output info to "NOCOW flag: set"
> >>
> >>  block/qapi.c         | 25 +++++++++++++++++++++++++
> >>  qapi/block-core.json |  5 ++++-
> >>  2 files changed, 29 insertions(+), 1 deletion(-)
> > 
> > This patch was sent on July 9th, after the 2.1 soft freeze when we stop
> > merging new features.  Soft freeze was 17th of June.
> > 
> > Please resend for QEMU 2.2 and update the qapi-schema.json version
> > comment.
> 
> There's still the argument that this is a bug fix for an incomplete
> implementation of a new feature that IS in qemu 2.1 (that is, 2.1 is
> adding the ability to set the nocow flag, but without this patch, that
> addition is a write-only interface, and this patch is correcting the bug
> to allow it to be a read-write interface).
> 
> But it is fairly late in the game - what is the level of damage if 2.1
> is released with a write-only setting, and this patch is deferred to
> 2.2?  Without some strong justification, I can agree with the decision
> to postpone this patch.

You can use lsattr(1), so I see no critical need.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]