From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC7hD-0000KC-7A for qemu-devel@nongnu.org; Tue, 29 Jul 2014 09:44:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XC7h6-0004ho-EG for qemu-devel@nongnu.org; Tue, 29 Jul 2014 09:44:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XC7f6-0004If-Pt for qemu-devel@nongnu.org; Tue, 29 Jul 2014 09:41:52 -0400 Date: Tue, 29 Jul 2014 14:41:43 +0100 From: Stefan Hajnoczi Message-ID: <20140729134143.GD25860@stefanha-thinkpad.redhat.com> References: <1404873793-7999-1-git-send-email-cyliu@suse.com> <20140728151941.GH13872@stefanha-thinkpad.redhat.com> <53D69D59.8060207@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hxkXGo8AKqTJ+9QI" Content-Disposition: inline In-Reply-To: <53D69D59.8060207@redhat.com> Subject: Re: [Qemu-devel] [PATCH for 2.1 V3] qemu-img info: show nocow info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Stefan Hajnoczi , Chunyan Liu , qemu-devel@nongnu.org --hxkXGo8AKqTJ+9QI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 28, 2014 at 12:58:33PM -0600, Eric Blake wrote: > On 07/28/2014 09:19 AM, Stefan Hajnoczi wrote: > > On Wed, Jul 09, 2014 at 10:43:13AM +0800, Chunyan Liu wrote: > >> Add nocow info in 'qemu-img info' output to show whether the file > >> currently has NOCOW flag set or not. > >> > >> Signed-off-by: Chunyan Liu > >> --- > >> Changes: > >> - update output info to "NOCOW flag: set" > >> > >> block/qapi.c | 25 +++++++++++++++++++++++++ > >> qapi/block-core.json | 5 ++++- > >> 2 files changed, 29 insertions(+), 1 deletion(-) > >=20 > > This patch was sent on July 9th, after the 2.1 soft freeze when we stop > > merging new features. Soft freeze was 17th of June. > >=20 > > Please resend for QEMU 2.2 and update the qapi-schema.json version > > comment. >=20 > There's still the argument that this is a bug fix for an incomplete > implementation of a new feature that IS in qemu 2.1 (that is, 2.1 is > adding the ability to set the nocow flag, but without this patch, that > addition is a write-only interface, and this patch is correcting the bug > to allow it to be a read-write interface). >=20 > But it is fairly late in the game - what is the level of damage if 2.1 > is released with a write-only setting, and this patch is deferred to > 2.2? Without some strong justification, I can agree with the decision > to postpone this patch. You can use lsattr(1), so I see no critical need. Stefan --hxkXGo8AKqTJ+9QI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT16SXAAoJEJykq7OBq3PIQLMH/0I8uxJUGzLeti5P8hDHPZMY PTwcCXEuDUaGhnV2XvRYXVtIK5mhzkQDMjuGHZKRULbMClk+du1LIiWwvaw4rnA5 BBCNaPnundqq52xhWkDxojot4uS24DbQ4hQbIvOk0FO4Nhvq5OwrECumlf8a0Gle iVf8jle/tYHwWbmNM9Cjzkx222i/HMvT6cNZe1EcqB8QB6CTjLjnWVr8qYT0WAB1 NjLPc7+3Ivf9k+oCogU+OKiEVmGqZH8hGxRkTRK0b98VW80Sf5snYK6rexWeKcxj n2Map47W0SbraE2m5xwjOpB1o9QEYw+QTEiRB5wVHVuYdiR1hcZvcDkyAkW9YIY= =POSR -----END PGP SIGNATURE----- --hxkXGo8AKqTJ+9QI--