From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47695)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XCPZN-0001VV-6v
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 04:49:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XCPZI-0006eS-Gi
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 04:49:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1164)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XCPZI-0006eM-8N
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 04:49:04 -0400
Date: Wed, 30 Jul 2014 16:49:22 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140730084922.GL16854@T430.nay.redhat.com>
References: <cover.1406204552.git.maria.k@catit.be>
	<b41ee554fa72a6fd52d52fbd17b82ee3bdeeb58d.1406204552.git.maria.k@catit.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b41ee554fa72a6fd52d52fbd17b82ee3bdeeb58d.1406204552.git.maria.k@catit.be>
Subject: Re: [Qemu-devel] [PATCH 2/4] runner: Make a copy of a test image
 for destructive test commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Maria Kustova <maxa@catit.be>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Maria Kustova <maria.k@catit.be>

On Thu, 07/24 16:32, Maria Kustova wrote:
> Signed-off-by: Maria Kustova <maria.k@catit.be>
> ---
>  tests/image-fuzzer/runner/runner.py | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/image-fuzzer/runner/runner.py b/tests/image-fuzzer/runner/runner.py
> index 3e9e65d..6ec40a4 100755
> --- a/tests/image-fuzzer/runner/runner.py
> +++ b/tests/image-fuzzer/runner/runner.py
> @@ -21,8 +21,8 @@
>  import sys, os, signal
>  import subprocess
>  import random
> +import shutil
>  from itertools import count
> -from shutil import rmtree
>  import getopt
>  try:
>      import json
> @@ -107,7 +107,9 @@ class TestEnv(object):
>                            'discard $off $len'],
>                           ['qemu-io', '$test_img', '-c',
>                            'truncate $off']]
> -        for fmt in ['raw', 'vmdk', 'vdi', 'cow', 'qcow2', 'file',
> +        # VMDK format is skipped because such conversion requires
> +        # a pregenerated vmdk file
> +        for fmt in ['raw', 'vdi', 'cow', 'qcow2', 'file',

How exactly doesn't VMDK work? I think qemu-img can handle it for you, and no
"pregenerated vmdk file" is needed.

>                      'qed', 'vpc']:
>              self.commands.append(
>                           ['qemu-img', 'convert', '-f', 'qcow2', '-O', fmt,
> @@ -146,7 +148,7 @@ class TestEnv(object):
>                                            'file', 'qed', 'vpc'])
>          backing_file_name = 'backing_img.' + backing_file_fmt
>          # Size of the backing file varies from 1 to 10 MB
> -        backing_file_size = random.randint(1, 10)*(1 << 20)
> +        backing_file_size = random.randint(1, 10) * (1 << 20)

This is not related to this patch.

Fam