From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49660)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XCPhI-0008Q7-PR
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 04:57:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XCPhD-0001Wr-Ug
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 04:57:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XCPhD-0001Wh-My
	for qemu-devel@nongnu.org; Wed, 30 Jul 2014 04:57:15 -0400
Date: Wed, 30 Jul 2014 10:57:32 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140730085732.GA14263@redhat.com>
References: <cover.1406703720.git.jan.kiszka@siemens.com>
	<592b4a2a2b00e21470bec1a2ecf259a64eb285b2.1406703720.git.jan.kiszka@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <592b4a2a2b00e21470bec1a2ecf259a64eb285b2.1406703720.git.jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat
	PC models
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote:
> We used to be able to address both the QEMU and the KVM APIC via "apic".
> This doesn't work anymore. So we need to use their parent class to turn
> off the vapic on machines that should not expose them.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>



OK so this is intended for 2.2?

In that case, how about creating a macro with type name,
and using that? This way things don't break if we rename
something again.

> ---
>  hw/i386/pc_piix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 9694f88..73ba77d 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -645,7 +645,7 @@ static QEMUMachine pc_machine_v1_1 = {
>              .property = "class",\
>              .value    = stringify(PCI_CLASS_MEMORY_RAM),\
>          },{\
> -            .driver   = "apic",\
> +            .driver   = "apic-common",\
>              .property = "vapic",\
>              .value    = "off",\
>          },{\
> -- 
> 1.8.1.1.298.ge7eed54