From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCRjC-0008LE-Tq for qemu-devel@nongnu.org; Wed, 30 Jul 2014 07:07:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCRj6-0006vy-BB for qemu-devel@nongnu.org; Wed, 30 Jul 2014 07:07:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCRj6-0006vq-20 for qemu-devel@nongnu.org; Wed, 30 Jul 2014 07:07:20 -0400 Date: Wed, 30 Jul 2014 13:07:36 +0200 From: "Michael S. Tsirkin" Message-ID: <20140730110736.GA15801@redhat.com> References: <53D4A56D.3070703@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53D4A56D.3070703@web.de> Subject: Re: [Qemu-devel] [PATCH] pci: Use bus master address space for delivering MSI/MSI-X messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Paolo Bonzini , qemu-devel On Sun, Jul 27, 2014 at 09:08:29AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > The spec says (and real HW confirms this) that, if the bus master bit > is 0, the device will not generate any PCI accesses. MSI and MSI-X > messages fall among these, so we should use the corresponding address > space to deliver them. This will prevent delivery if bus master support > is disabled. > > Signed-off-by: Jan Kiszka Reviewed-by: Michael S. Tsirkin Pls remember to repost when 2.1 is out. Thanks! > --- > hw/pci/msi.c | 2 +- > hw/pci/msix.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/pci/msi.c b/hw/pci/msi.c > index a4a3040..52d2313 100644 > --- a/hw/pci/msi.c > +++ b/hw/pci/msi.c > @@ -291,7 +291,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector) > "notify vector 0x%x" > " address: 0x%"PRIx64" data: 0x%"PRIx32"\n", > vector, msg.address, msg.data); > - stl_le_phys(&address_space_memory, msg.address, msg.data); > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); > } > > /* Normally called by pci_default_write_config(). */ > diff --git a/hw/pci/msix.c b/hw/pci/msix.c > index 5c49bfc..20ae476 100644 > --- a/hw/pci/msix.c > +++ b/hw/pci/msix.c > @@ -439,7 +439,7 @@ void msix_notify(PCIDevice *dev, unsigned vector) > > msg = msix_get_message(dev, vector); > > - stl_le_phys(&address_space_memory, msg.address, msg.data); > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); > } > > void msix_reset(PCIDevice *dev) > -- > 1.8.1.1.298.ge7eed54 >