From: Stefan Hajnoczi <stefanha@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: amit.shah@redhat.com, lcapitulino@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize
Date: Wed, 30 Jul 2014 16:26:07 +0100 [thread overview]
Message-ID: <20140730152607.GK597@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1406676538-23149-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Tue, Jul 29, 2014 at 07:28:56PM -0400, John Snow wrote:
> My previous commit, 713e8a10, did not address the fact that
> the error checking pathways do not attempt to call
> virtio_cleanup and thus can leak memory in hotplug scenarios.
>
> This patchset shuffles around the error checking so it does not
> need to perform said cleanup, and changes the error functions
> from error_set to error_setg.
>
> John Snow (2):
> virtio-rng: Move error-checking forward to prevent memory leak
> virtio-rng: replace error_set calls with error_setg
>
> hw/virtio/virtio-rng.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-07-30 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 23:28 [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize John Snow
2014-07-29 23:28 ` [Qemu-devel] [PATCH 1/2] virtio-rng: Move error-checking forward to prevent memory leak John Snow
2014-07-29 23:28 ` [Qemu-devel] [PATCH 2/2] virtio-rng: replace error_set calls with error_setg John Snow
2014-07-30 5:57 ` [Qemu-devel] [PATCH 0/2] virtio-rng: Fix memory leaks in virtio_rng_device_realize Markus Armbruster
2014-07-30 15:26 ` Stefan Hajnoczi [this message]
2014-08-01 5:09 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730152607.GK597@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).