From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCl53-0003U8-E5 for qemu-devel@nongnu.org; Thu, 31 Jul 2014 03:47:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCl4x-0005VE-0S for qemu-devel@nongnu.org; Thu, 31 Jul 2014 03:47:17 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:56468 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCl4w-0005V7-Mh for qemu-devel@nongnu.org; Thu, 31 Jul 2014 03:47:10 -0400 Date: Thu, 31 Jul 2014 09:46:25 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140731074624.GD707@irqsave.net> References: <1406710411-26373-1-git-send-email-stefanha@redhat.com> <1406710411-26373-3-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1406710411-26373-3-git-send-email-stefanha@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/2] qemu-iotests: add multiwrite test cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , andrey@xdel.ru, Fam Zheng , qemu-devel@nongnu.org, sviatoslav.pestov@gmail.com The Wednesday 30 Jul 2014 =E0 09:53:31 (+0100), Stefan Hajnoczi wrote : > This test case covers the basic bdrv_aio_multiwrite() scenarios: > 1. Single request > 2. Sequential requests (AABB) > 3. Superset overlapping requests (AABBAA) > 4. Subset overlapping requests (BBAABB) > 5. Head overlapping requests (AABB) > 6. Tail overlapping requests (BBAA) > 7. Disjoint requests (AA BB) >=20 > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/100 | 134 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/100.out | 89 ++++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 224 insertions(+) > create mode 100755 tests/qemu-iotests/100 > create mode 100644 tests/qemu-iotests/100.out >=20 > diff --git a/tests/qemu-iotests/100 b/tests/qemu-iotests/100 > new file mode 100755 > index 0000000..9124aba > --- /dev/null > +++ b/tests/qemu-iotests/100 > @@ -0,0 +1,134 @@ > +#!/bin/bash > +# > +# Test simple read/write using plain bdrv_read/bdrv_write > +# > +# Copyright (C) 2014 Red Hat, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see = . > +# > + > +# creator > +owner=3Dstefanha@redhat.com > + > +seq=3D`basename $0` > +echo "QA output created by $seq" > + > +here=3D`pwd` > +tmp=3D/tmp/$$ > +status=3D1 # failure is the default! > + > +_cleanup() > +{ > + _cleanup_test_img > +} > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +# get standard environment, filters and checks > +. ./common.rc > +. ./common.filter > + > +_supported_fmt generic > +_supported_proto generic > +_supported_os Linux > + > + > +size=3D128M > + > +echo > +echo "=3D=3D Single request =3D=3D" > +_make_test_img $size > +$QEMU_IO -c "multiwrite 0 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D verify pattern =3D=3D" > +$QEMU_IO -c "read -P 0xcd 0 4k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 4k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D Sequential requests =3D=3D" > +_make_test_img $size > +$QEMU_IO -c "multiwrite 0 4k ; 4k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D verify pattern =3D=3D" > +$QEMU_IO -c "read -P 0xcd 0 4k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0xce 4k 4k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 8k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D Superset overlapping requests =3D=3D" > +_make_test_img $size > +$QEMU_IO -c "multiwrite 0 4k ; 1k 2k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D verify pattern =3D=3D" > +# Order of overlapping in-flight requests is not guaranteed so we cann= ot verify > +# [1k, 3k) since it could have either pattern 0xcd or 0xce. > +$QEMU_IO -c "read -P 0xcd 0 1k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0xcd 3k 1k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 4k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D Subset overlapping requests =3D=3D" > +_make_test_img $size > +$QEMU_IO -c "multiwrite 1k 2k ; 0k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D verify pattern =3D=3D" > +# Order of overlapping in-flight requests is not guaranteed so we cann= ot verify > +# [1k, 3k) since it could have either pattern 0xcd or 0xce. > +$QEMU_IO -c "read -P 0xce 0 1k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0xce 3k 1k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 4k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D Head overlapping requests =3D=3D" > +_make_test_img $size > +$QEMU_IO -c "multiwrite 0k 2k ; 0k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D verify pattern =3D=3D" > +# Order of overlapping in-flight requests is not guaranteed so we cann= ot verify > +# [0k, 2k) since it could have either pattern 0xcd or 0xce. > +$QEMU_IO -c "read -P 0xce 2k 2k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 4k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D Tail overlapping requests =3D=3D" > +_make_test_img $size > +$QEMU_IO -c "multiwrite 2k 2k ; 0k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D verify pattern =3D=3D" > +# Order of overlapping in-flight requests is not guaranteed so we cann= ot verify > +# [2k, 4k) since it could have either pattern 0xcd or 0xce. > +$QEMU_IO -c "read -P 0xce 0k 2k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 4k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D Disjoint requests =3D=3D" > +_make_test_img $size > +$QEMU_IO -c "multiwrite 0 4k ; 64k 4k" "$TEST_IMG" | _filter_qemu_io > + > +echo > +echo "=3D=3D verify pattern =3D=3D" > +$QEMU_IO -c "read -P 0xcd 0 4k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 4k 60k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0xce 64k 4k" "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c "read -P 0 68k 4k" "$TEST_IMG" | _filter_qemu_io > + > +# success, all done > +echo "*** done" > +rm -f $seq.full > +status=3D0 > diff --git a/tests/qemu-iotests/100.out b/tests/qemu-iotests/100.out > new file mode 100644 > index 0000000..2d6e9f0 > --- /dev/null > +++ b/tests/qemu-iotests/100.out > @@ -0,0 +1,89 @@ > +QA output created by 100 > + > +=3D=3D Single request =3D=3D > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 > +wrote 4096/4096 bytes at offset 0 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D verify pattern =3D=3D > +read 4096/4096 bytes at offset 0 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 4096 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D Sequential requests =3D=3D > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 > +wrote 8192/8192 bytes at offset 0 > +8 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D verify pattern =3D=3D > +read 4096/4096 bytes at offset 0 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 4096 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 8192 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D Superset overlapping requests =3D=3D > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 > +wrote 6144/6144 bytes at offset 0 > +6 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D verify pattern =3D=3D > +read 1024/1024 bytes at offset 0 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 1024/1024 bytes at offset 3072 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 4096 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D Subset overlapping requests =3D=3D > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 > +wrote 6144/6144 bytes at offset 1024 > +6 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D verify pattern =3D=3D > +read 1024/1024 bytes at offset 0 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 1024/1024 bytes at offset 3072 > +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 4096 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D Head overlapping requests =3D=3D > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 > +wrote 6144/6144 bytes at offset 0 > +6 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D verify pattern =3D=3D > +read 2048/2048 bytes at offset 2048 > +2 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 4096 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D Tail overlapping requests =3D=3D > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 > +wrote 6144/6144 bytes at offset 2048 > +6 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D verify pattern =3D=3D > +read 2048/2048 bytes at offset 0 > +2 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 4096 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D Disjoint requests =3D=3D > +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 > +wrote 8192/8192 bytes at offset 0 > +8 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > + > +=3D=3D verify pattern =3D=3D > +read 4096/4096 bytes at offset 0 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 61440/61440 bytes at offset 4096 > +60 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 65536 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +read 4096/4096 bytes at offset 69632 > +4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +*** done > diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group > index 6e67f61..8e2215e 100644 > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -100,3 +100,4 @@ > 091 rw auto quick > 092 rw auto quick > 095 rw auto quick > +100 rw auto quick > --=20 > 1.9.3 >=20 >=20 Reviewed-by: Benoit Canet