From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCpYj-0006Sy-Q3 for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:34:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCpYa-00054l-PF for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:34:13 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:57287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCpYa-00054h-IE for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:34:04 -0400 Received: by mail-wg0-f50.google.com with SMTP id n12so2731059wgh.9 for ; Thu, 31 Jul 2014 05:34:03 -0700 (PDT) Date: Thu, 31 Jul 2014 13:33:57 +0100 From: Stefan Hajnoczi Message-ID: <20140731123357.GU25929@stefanha-thinkpad.redhat.com> References: <1404757089-4836-1-git-send-email-jsnow@redhat.com> <1404757089-4836-19-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0rpW5bEisVBStM29" Content-Disposition: inline In-Reply-To: <1404757089-4836-19-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH 18/28] q35: Enable the ioapic device to be seen by qtest. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: pbonzini@redhat.com, Andreas Faerber , qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com --0rpW5bEisVBStM29 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 07, 2014 at 02:17:59PM -0400, John Snow wrote: > Currently, the ioapic device can not be found in a qtest environment > when requesting "irq_interrupt_in ioapic" via the qtest socket. >=20 > By mirroring how the ioapic is added in i44ofx (hw/i440/pc_piix.c), > as a child of "q35," the device is able to be seen by qtest. >=20 > Signed-off-by: John Snow > --- > hw/i386/pc_q35.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 36b6ab0..143b978 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -231,7 +231,7 @@ static void pc_q35_init(MachineState *machine) > gsi_state->i8259_irq[i] =3D i8259[i]; > } > if (pci_enabled) { > - ioapic_init_gsi(gsi_state, NULL); > + ioapic_init_gsi(gsi_state, "q35"); > } > qdev_init_nofail(icc_bridge); > =20 > --=20 > 1.9.3 Reviewed-by: Stefan Hajnoczi --0rpW5bEisVBStM29 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT2je1AAoJEJykq7OBq3PIQ2UIAKidZ9/ka9CAQrpkU/HZr2gH Z1BxIGHwoBB69igW0Ec+0ixHVQyh+v91Ya+hqid+bjGO5V6ZEiYUyJcxaVuUE4IA PA2NXPPTkBIgxulC3Ewf711AmlKMGrUr8asaxepFMMhARmYhCNn7MG7YVuIsfebk xN+7ti2BVgjJ52fMwk4pASyRlNPalnmS8/PQqBxeEFhS9G6augSH0Ae/MFP84LcH xScyd1QgQOyHdXdYx3+mcP6RLfXp3OIwL3Y5xqegPaSuLUyhSP9Y5kjH0/q8JM/e uU9WwgMvAVrnl4udUl1j8db5GITZT8I5apVdBoyweOBVMBC8Mjc/8ZPcLdiUDYo= =je+i -----END PGP SIGNATURE----- --0rpW5bEisVBStM29--